Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #402 - Mistake in hindi conversion of "Crop" #410

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Fixes #402 - Mistake in hindi conversion of "Crop" #410

merged 4 commits into from
Jul 20, 2022

Conversation

pratyaksh1610
Copy link
Contributor

close #402

Bug

Mistake in hindi conversion of "Crop"

Cause:

Improper translation

Reproduce

It is showing "Crop" = फसल
It will be "Crop" = काटे

How the bug was solved:

Fixed the Mistake in hindi conversion of "Crop" . res/values-hi/strings.xml

@pratyaksh1610 pratyaksh1610 requested a review from a team as a code owner July 20, 2022 05:25
CHANGELOG.md Outdated

## [4.3.0] - 20/07/22
### Fixed
- Fixed the mistake in hindi conversion of "Crop" [#402](https://github.com/CanHub/Android-Image-Cropper/issues/402)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this line to the [x.x.x] - unreleased session on the top

CHANGELOG.md Outdated
@@ -19,6 +19,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Added
- CropImageOptions: Option to change progress bar color. [#390](https://github.com/CanHub/Android-Image-Cropper/issues/390)

## [4.3.0] - 20/07/22
Copy link
Member

@Canato Canato Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.3.0 is already released, should be on the [x.x.x] - unreleased part

@Canato Canato enabled auto-merge (squash) July 20, 2022 10:59
@Canato Canato merged commit a2ee60f into CanHub:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mistake in hindi conversion of "Crop"
2 participants