Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt carto.js to Google Maps v3.32 / v3.31 #2067

Closed
ivanmalagon opened this issue Mar 5, 2018 · 6 comments
Closed

Adapt carto.js to Google Maps v3.32 / v3.31 #2067

ivanmalagon opened this issue Mar 5, 2018 · 6 comments

Comments

@ivanmalagon
Copy link
Contributor

On February 13th, 2018 Google released a new experimental version of Google Maps (v3.32) that doesn't get along with CARTO.js.

The problems seem related to some race condition or us doing things before the script is ready. That was not happening with previous versions.

We are now operating on the frozen version (v3.30) and still have the cushion of v3.31, but we should tackle this. Google Maps bumps version every 3 - 4 months so that's the time we have

@knownasilya
Copy link
Contributor

knownasilya commented Mar 22, 2018

The biggest issue is that the layers from Carto don't show on initial load, but do show up once you start zooming. I'd love to see this working, especially since 3.32 contains the new beta renderer which is 👌

@VictorVelarde VictorVelarde changed the title Adapt carto.js to Google Maps v3.32 Adapt carto.js to Google Maps v3.32 / v3.31 Apr 25, 2018
@VictorVelarde
Copy link
Contributor

VictorVelarde commented Apr 25, 2018

Hi @knownasilya

We have been testing gmaps 3.32 and it seems that there are no more issues by now (v3.32.12).

But this version is still experimental, so we have decided to allow just the currently stableversion 3.31 and to wait for next release. This has been included in our new carto.js v4.0.1, available at NPM.

We have also updated our development docs at https://carto.com/developers/carto-js/ (see for example this gmaps map)

As a reference, this is the official doc for Google Maps releases

@ivanmalagon
Copy link
Contributor Author

ivanmalagon commented May 31, 2018

Reopening. -> https://github.com/CartoDB/support/issues/1568

This is happening for 3.15 and 4 as well. JLL is affected by v4.

@ivanmalagon
Copy link
Contributor Author

After spending the whole day trying to know what the issue is with cartodb.js v3, I ended up filing an issue to Google Maps team.

https://issuetracker.google.com/issues/80553979

I couldn't make any fix for that and I hope to get an answer for them. So far, there's nothing more we can do but I'll be on top of this, since it can break our library with GMaps. Depending on the answer, perhaps we need to rethink / refactor how we render CARTO.js with GMaps. 😨

Regarding JLL we need more info. Are they suffering from the very same issue or are they getting another error? We need that feedback to tackle it correctly in v4.

@ivanmalagon
Copy link
Contributor Author

Fixed for cartodb.js v3 at v3.15.15

To get the last version -> http://libs.cartocdn.com/cartodb.js/v3/3.15/cartodb.js

@ivanmalagon
Copy link
Contributor Author

Closing.

The JLL problem is not related to GMaps 3.32. It has now its own ticket. #2132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants