Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gmaps to v3.32 in v4 [WIP] #2126

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Update gmaps to v3.32 in v4 [WIP] #2126

merged 2 commits into from
Jun 4, 2018

Conversation

VictorVelarde
Copy link
Contributor

@VictorVelarde VictorVelarde commented May 31, 2018 •
edited
Loading

There are several issues, regarding to the new gmaps v3.32 version, as noticed in #2067

A fix is needed for current v4 and v3 versions.

Tasks:

  • Update to accept currently stable version: v3.32
  • Current unit tests OK with browser & jasmine using v3.32
  • Update gmaps examples
  • Reproduce errors on mobile devices
  • ...

@VictorVelarde VictorVelarde mentioned this pull request May 31, 2018
Closed
@VictorVelarde VictorVelarde changed the title Update gmaps to v3.32 [WIP] Update gmaps to v3.32 in v4 [WIP] May 31, 2018
@ivanmalagon ivanmalagon merged commit ae9c113 into master Jun 4, 2018
@ivanmalagon ivanmalagon deleted the gmaps-3-32 branch June 4, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorVelarde @ivanmalagon