Add performance tips to CARTO.js docs #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
reviewed
Jul 11, 2018
src/api/v4/source/dataset.js
Outdated
| * @returns {Promise} - A promise that will be fulfilled when the reload cycle is completed | ||
| * @api | ||
| */ | ||
| Dataset.prototype.setDataset = function (tableName) { |
There was a problem hiding this comment.
I would use setTableName for that function since dataset.setDataset(tableName) is a bit confusing
inigomedina
reviewed
Jul 12, 2018
docs/guides/04-performance-tips.md
Outdated
|
|
||
| These style instances work the same way as sources do. It is pretty common to change styles in your map based on certain triggers, so that you can adequate your visualization to what you want to show. | ||
|
|
||
| When linked to a layer, the will automatically show the style change by invoking `.setContent` on the style object with a string containing the new style content. |
There was a problem hiding this comment.
When linked to a layer, the will automatically show...
I am not sure if you wanted to say here they will automatically show.
|
retest this please (not human retest 😂 ) |
inigomedina
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2168
Description
This PR adds a
Performance Guideto the documentation to explain howsource,style,layeranddataviewsinteract with each other and how to change their attributes correctly.This PR also implements
.setDatasetincarto.source.Datasetwith the same behavior assetQueryincarto.source.SQL