Fix popups/featureClick positions when scrolled #2179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/CartoDB/support/issues/1659
So this has been broken since we introduced zera, but probably never seen it because we almost never have maps that are not full screen (iframes work just fine). I've attached an example that would be broken with the previous implementation if you scroll vertically or horizontally. Feel free to try it out on master.
I assume there's some difference between what we're getting with zera and what we used to get with wax. The thing is, there's apparently a Leaflet method that retrieves the containerPoint from the layerPoint, it seems to work perfectly.