Fix safari drag problem #2184
Merged
Fix safari drag problem #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rubenmoya
force-pushed
the
fix-safari-drag
branch
from
6655714 to
31b5ea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: CartoDB/cartodb#14115
Description
This PR fixes a bug introduced in CartoDB/zera@317a82f while trying to fix #1952
The problem is that Builder is listening directly to document click events, so it closes the edit button as soon as soon as it's shown. Instead of stopping the event propagation to avoid that error we're going to handle it using carto.js events and stop listening to document click.