-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update api key #2227
update api key #2227
Conversation
We need to add the new API key for Google Maps examples. This is the first update to see if it works properly. If it works, I'm going to update the rest of examples.
Hi @inigomedina , thx for pushing this! After reading the original issue (https://github.com/CartoDB/developers/issues/514), I think we are going to tackle this from RT, so I'm pinging here @rjimenezda The main steps are probably pretty clear:
developers
If any situation arises with this, we can make the proper updates here, or talk together. |
Thanks a lot, @VictorVelarde. The plan sounds perfect. 🔝 |
Hi @inigomedina I'm trying this locally, and it seems like localhost is not allowed as a host. Could you please try to authorize it? This doesn't happen with the old keys, I get a quota error. If you still have access to the old key, please make sure that all the allowed referers are the same. I can take care of updating everything. @VictorVelarde So I should upgrade the version as well? It's 3.32 right now |
@jvillarf was the person in charge of that part on this issue. He precisely talked about this, because he restricted referrers to cc @jvillarf |
@inigomedina @ramiroaznar i've just disabled the referrer restriction, so you can test it locally. Would you please go ahead? (GCloud dashboar says the change can take up to 5 minutes, so be patient). Once you have finished and we are ready for Production, please ping me again, so i can set the referrer restriction again. Thanks. |
How can I test this? |
Sorry @ramiroaznar i wanted to ping @rjimenezda instead of you and autocomplete played with me 😿 |
Thanks @jvillarf, I'll go ahead and change it for all. Will ping you as soon as we can block localhost again |
@@ -104,12 +104,12 @@ <h1>Change the feature columns</h1> | |||
|
|||
function setMoreData() { | |||
layer.setFeatureClickColumns(['name', 'pop_max', 'pop_min']); | |||
document.getElementById('content').innerHTML = ''; | |||
document.getElementById('info').innerHTML = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this broken because of a wrong id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but nothing serious, that's only used to "clear" a text. I noticed when checking all examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good boy scout 😄 !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can for that release
Working in prod |
Nice! 👏 |
💥 |
We need to add the new API key for Google Maps examples. This is the first update to see if it works properly. If it works, I'm going to update the rest of the examples.