New dataview filters: circle & polygon #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorVelarde
force-pushed
the
feature/new-geom-filters
branch
2 times, most recently
from
73cf4e3 to
580f4d1
Compare
VictorVelarde
changed the title
VictorVelarde
force-pushed
the
feature/new-geom-filters
branch
2 times, most recently
from
751884b to
d5d4525
Compare
VictorVelarde
force-pushed
the
feature/new-geom-filters
branch
from
97135d1 to
41f7b9f
Compare
VictorVelarde
force-pushed
the
feature/new-geom-filters
branch
from
246f7cf to
0730d07
Compare
csubira
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2237
Fixes #2240
[WIP] Addition of new spatial filters to Dataviews (Circle & Polygon filters):
TASKS:
Circle filter
dataviews:
Polygon filter
dataviews:
Besides carto.js tests, let's test that no change affect internal (widgets on dataviews)
To be coordinated with Windshaft related changes at CartoDB/Windshaft-cartodb#1150