Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tooltips from being shown when no fields have been selected #486

Merged
merged 2 commits into from
May 22, 2015
Merged

Prevent tooltips from being shown when no fields have been selected #486

merged 2 commits into from
May 22, 2015

Conversation

alonsogarciapablo
Copy link
Contributor

This fixes CartoDB/cartodb#3617. The problems were:

  1. There was a layer filled with features (timezones) on top of the map. So we were hovering a feature all the time.
  2. We were adding the tooltip cause the other layer had a tooltip (with fields) and we were not checking if layers have fields in the tooltip when we enable.

This PR fixes that by preventing a tooltip from being shown if there are no fields.

cc// @javisantana

@javisantana
Copy link
Contributor

🇪🇸

alonsogarciapablo added a commit that referenced this pull request May 22, 2015
@alonsogarciapablo
Merge pull request #486 from CartoDB/cdb-3617-tooltips-with-no-fields
e75eaa0 
Prevent tooltips from being shown when no fields have been selected
@alonsogarciapablo alonsogarciapablo merged commit e75eaa0 into develop May 22, 2015
@alonsogarciapablo alonsogarciapablo deleted the cdb-3617-tooltips-with-no-fields branch May 22, 2015 09:25
@alonsogarciapablo alonsogarciapablo mentioned this pull request May 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alonsogarciapablo @javisantana