Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] no notification in tray when app in foreground (like firebase) #109

Conversation

kreativ-software
Copy link
Contributor

@phongcao
Copy link
Collaborator

phongcao commented Mar 3, 2020

Looks good to me. Thanks @kreativ-software!

@phongcao phongcao merged commit a4f82f1 into CatalystCode:master Mar 3, 2020
@CDBridger
Copy link

CDBridger commented Jul 8, 2020

This isn't a fix at all, this is changing how the software works.

This is considered to be a a critical regression by one of my clients in which we use this library as being able to view the notification history in the system bar is a huge boon as opposed to it having no record at all if they missed it or ignored it while the app is in the foreground.

It would be nice if this had been left as an option or flag that could be passed rather than just merged in like that to suit somebody elses needs while breaking others. Now currently I have to fork and maintain this library or roll back at the same time as losing the other fixes that were part of the latest version bump.

@phongcao
Copy link
Collaborator

phongcao commented Jul 8, 2020

@CDBridger The scenario that you've described makes sense to me. I may add a flag to enable that behavior when registering for notification hub in the next release. Sorry for your inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants