Standardize openshift roles to OASIS #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14rcole
reviewed
Mar 11, 2020
| platforms: | ||
| - name: openshift | ||
| image: centos:7 | ||
| ## Remove 'image' above and uncomment the following to run systemd in Docker |
14rcole
reviewed
Mar 11, 2020
| @@ -82,23 +81,28 @@ | |||
|
|
|||
| - name: fail when pod_output is failure | |||
| fail: | |||
| msg: "Multiple pods in pending/failure state please adjust the timeout value and retry" | |||
| when: state == "present" and pod_output == 'Failure' | |||
| msg: "Multiple pods in pending/failure \ | |||
There was a problem hiding this comment.
Are you sure this works the way you expect it to? Generally in yaml the way to split a string across multiple lines is this:
msg: >
Multiple pods in pending/failure state, please adjust
the timeout value and retry
There was a problem hiding this comment.
@14rcole I tested it with a simple debug msg task. I went fine.
I can change it to the above format if its the general standard.
There was a problem hiding this comment.
I did the above for the other modules, but we can standardize on whichever one you prefer
There was a problem hiding this comment.
@14rcole When I use the above syntax ansible lint was failing.
samvarankashyap
force-pushed
the
standardize_openshift
branch
2 times, most recently
from
40fd9f4 to
1057d0e
Compare
14rcole
approved these changes
Mar 13, 2020
samvarankashyap
force-pushed
the
standardize_openshift
branch
from
1057d0e to
6dbb087
Compare
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$Subject
fixes #1657