Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Improved deep clean for multiple vm and fix the mock data issue #1688

Merged
merged 3 commits into from
Mar 16, 2020
Merged

WIP Improved deep clean for multiple vm and fix the mock data issue #1688

merged 3 commits into from
Mar 16, 2020

Conversation

JunqiZhang0
Copy link
Contributor

@JunqiZhang0 JunqiZhang0 commented Mar 12, 2020 •
edited by samvarankashyap
Loading

Improved deep clean for multiple VM and fix the mock data issue. Should partially #1681 and fix #1692

@adl-bot
Copy link

adl-bot commented Mar 12, 2020

Can one of the admins verify this patch?

@JunqiZhang0
Copy link
Contributor Author

[test]

1 similar comment
@JunqiZhang0
Copy link
Contributor Author

[test]

@14rcole
Copy link
Contributor

14rcole commented Mar 12, 2020

@JunqiZhang0 is there an issue that you can link to this?

@samvarankashyap samvarankashyap self-requested a review March 16, 2020 14:18
samvarankashyap
samvarankashyap approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@samvarankashyap samvarankashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunqiZhang0
Copy link
Contributor Author

[merge]

@adl-bot adl-bot merged commit a04466a into CentOS-PaaS-SIG:develop Mar 16, 2020
@samvarankashyap samvarankashyap linked an issue Mar 17, 2020 that may be closed by this pull request
bug: azure_rm_manageddisk missing mock data #1687
Closed
@samvarankashyap samvarankashyap mentioned this pull request Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvarankashyap samvarankashyap samvarankashyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The leftover of Azure should be cleaned bug: azure_rm_manageddisk missing mock data
4 participants
@JunqiZhang0 @adl-bot @14rcole @samvarankashyap