Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libvirt mock tests to github actions #1705

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Add libvirt mock tests to github actions #1705

merged 1 commit into from
Mar 24, 2020

Conversation

samvarankashyap
Copy link
Contributor

@samvarankashyap samvarankashyap commented Mar 24, 2020 •
edited
Loading

Summary:

  • Added mock tests to libvirt
  • Tasks without names have been updated to have names
  • Updated names of few tasks for easier identification of task inside plugins
  • added mock data to tasks.

fixes #1542

@samvarankashyap samvarankashyap requested a review from 14rcole March 24, 2020 12:53
@samvarankashyap samvarankashyap mentioned this pull request Mar 24, 2020
Merged
14rcole
14rcole approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@14rcole 14rcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samvarankashyap
Copy link
Contributor Author

[merge]

@adl-bot adl-bot merged commit edcc914 into CentOS-PaaS-SIG:develop Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@14rcole 14rcole 14rcole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mock integration tests for Libvirt provider
3 participants
@samvarankashyap @14rcole @adl-bot