[Django Upgrade] Move schema activeness/visibility update to pytest f…

…ixtures (#10029)

api_tests/draft_registrations/views/test_draft_registration_list.py

@@ -8,6 +8,7 @@
 )
 from api.base.settings.defaults import API_BASE
 
+from osf.migrations import ensure_invisible_and_inactive_schema
 from osf.models import DraftRegistration, NodeLicense, RegistrationProvider, Institution
 from osf_tests.factories import (
     RegistrationFactory,
@@ -20,6 +21,12 @@
 
 from website import mails, settings
 
+
+@pytest.fixture(autouse=True)
+def invisible_and_inactive_schema():
+    return ensure_invisible_and_inactive_schema()
+
+
 @pytest.mark.django_db
 class TestDraftRegistrationListNewWorkflow(TestDraftRegistrationList):
     @pytest.fixture()

api_tests/nodes/views/test_node_draft_registration_list.py

@@ -3,6 +3,7 @@
 
 from api.base.settings.defaults import API_BASE
 from framework.auth.core import Auth
+from osf.migrations import ensure_invisible_and_inactive_schema
 from osf.models import RegistrationSchema, RegistrationProvider
 from osf_tests.factories import (
     ProjectFactory,
@@ -20,6 +21,12 @@
 OPEN_ENDED_SCHEMA_VERSION = 3
 SCHEMA_VERSION = 2
 
+
+@pytest.fixture(autouse=True)
+def invisible_and_inactive_schema():
+    return ensure_invisible_and_inactive_schema()
+
+
 @pytest.mark.django_db
 class DraftRegistrationTestCase:
 

api_tests/schemas/views/test_registration_schemas_detail.py

@@ -1,6 +1,7 @@
 import pytest
 
 from api.base.settings.defaults import API_BASE
+from osf.migrations import ensure_invisible_and_inactive_schema
 from osf.models import RegistrationSchema
 from osf_tests.factories import (
     AuthUserFactory,
@@ -10,10 +11,12 @@
 
 SCHEMA_VERSION = 2
 
+
 @pytest.fixture()
 def user():
     return AuthUserFactory()
 
+
 @pytest.fixture()
 def schema():
     return RegistrationSchema.objects.filter(
@@ -22,6 +25,11 @@ def schema():
     ).first()
 
 
+@pytest.fixture(autouse=True)
+def invisible_and_inactive_schema():
+    return ensure_invisible_and_inactive_schema()
+
+
 class TestDeprecatedMetaSchemaDetail:
     def test_deprecated_metaschemas_routes(self, app, user, schema):
         # test base /metaschemas/ GET with min version

osf/migrations/__init__.py

@@ -234,7 +234,7 @@ def ensure_default_storage_region():
 
 
 def ensure_datacite_file_schema():
-    ''' Test use only '''
+    """ Test use only """
     from osf.models import FileMetadataSchema
     with open('osf/metadata/schemas/datacite.json') as f:
         jsonschema = json.load(f)
@@ -246,3 +246,18 @@ def ensure_datacite_file_schema():
             'schema': jsonschema
         }
     )
+
+
+def ensure_invisible_and_inactive_schema():
+    """ Test use only """
+    from osf.models import RegistrationSchema
+    v2_inactive_schema = [
+        'EGAP Project',
+        'OSF Preregistration',
+        'Confirmatory - General',
+        'RIDIE Registration - Study Complete',
+        'RIDIE Registration - Study Initiation',
+    ]
+    v2_inactive_schema = v2_inactive_schema + ['Election Research Preacceptance Competition']
+    RegistrationSchema.objects.filter(name__in=v2_inactive_schema).update(visible=False)
+    RegistrationSchema.objects.filter(name__in=v2_inactive_schema).update(active=False)