Re-add non-anonymized fields removed in #10009 #10022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
into remove-quickfiles-code * 'develop' of https://github.com/CenterForOpenScience/osf.io: (44 commits) Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654] [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) Instrument the ORCiD SSO affiliation flow * Existing user with verified ORCiD ID * Existing user confirmation of linking ORCiD ID * New user confirmation of account creation with ORCiD ID Add a django command script to handle instn sso email domain changes Bump version and CHANGELOG Add better logic for routing Dataverse files and their stupid duplicate (CenterForOpenScience#9963) [ENG-3872] Fix dataverse 502s and pass version info to FE (CenterForOpenScience#9959) Fix File `show_as_unviewed` behavior (CenterForOpenScience#9960) Fix OSFUser.has_resources ... # Conflicts: # api_tests/files/views/test_file_detail.py # osf/models/nodelog.py # osf/models/user.py # tests/test_addons.py # website/static/js/anonymousLogActionsList.json # website/static/js/logActionsList.json
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
into remove-quickfiles-code * 'develop' of https://github.com/CenterForOpenScience/osf.io: (44 commits) Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654] [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) Instrument the ORCiD SSO affiliation flow * Existing user with verified ORCiD ID * Existing user confirmation of linking ORCiD ID * New user confirmation of account creation with ORCiD ID Add a django command script to handle instn sso email domain changes Bump version and CHANGELOG Add better logic for routing Dataverse files and their stupid duplicate (CenterForOpenScience#9963) [ENG-3872] Fix dataverse 502s and pass version info to FE (CenterForOpenScience#9959) Fix File `show_as_unviewed` behavior (CenterForOpenScience#9960) Fix OSFUser.has_resources ... # Conflicts: # api_tests/files/views/test_file_detail.py # osf/models/nodelog.py # osf/models/user.py # tests/test_addons.py # website/static/js/anonymousLogActionsList.json # website/static/js/logActionsList.json
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
into remove-quickfiles-code * 'develop' of https://github.com/CenterForOpenScience/osf.io: (44 commits) Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654] [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) Instrument the ORCiD SSO affiliation flow * Existing user with verified ORCiD ID * Existing user confirmation of linking ORCiD ID * New user confirmation of account creation with ORCiD ID Add a django command script to handle instn sso email domain changes Bump version and CHANGELOG Add better logic for routing Dataverse files and their stupid duplicate (CenterForOpenScience#9963) [ENG-3872] Fix dataverse 502s and pass version info to FE (CenterForOpenScience#9959) Fix File `show_as_unviewed` behavior (CenterForOpenScience#9960) Fix OSFUser.has_resources ... # Conflicts: # api_tests/files/views/test_file_detail.py # osf/models/nodelog.py # osf/models/user.py # tests/test_addons.py # website/static/js/anonymousLogActionsList.json # website/static/js/logActionsList.json
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
into remove-quickfiles-code * 'develop' of https://github.com/CenterForOpenScience/osf.io: (44 commits) Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654] [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) Instrument the ORCiD SSO affiliation flow * Existing user with verified ORCiD ID * Existing user confirmation of linking ORCiD ID * New user confirmation of account creation with ORCiD ID Add a django command script to handle instn sso email domain changes Bump version and CHANGELOG Add better logic for routing Dataverse files and their stupid duplicate (CenterForOpenScience#9963) [ENG-3872] Fix dataverse 502s and pass version info to FE (CenterForOpenScience#9959) Fix File `show_as_unviewed` behavior (CenterForOpenScience#9960) Fix OSFUser.has_resources ... # Conflicts: # api_tests/files/views/test_file_detail.py # osf/models/nodelog.py # osf/models/user.py # tests/test_addons.py # website/static/js/anonymousLogActionsList.json # website/static/js/logActionsList.json
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
…OpenScience/osf.io into django-3-2 * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654]
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
…OpenScience/osf.io into django-3-2 * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654]
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
…OpenScience/osf.io into django-3-2 * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654]
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 16, 2022
…OpenScience/osf.io into django-3-2 * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654]
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 17, 2022
…OpenScience/osf.io into django-3-squash-only * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [Django Upgrade] Upgrade markdown and mdx_del_ins (CenterForOpenScience#9984) [Django Upgrade] Replace M2M direct assignment (CenterForOpenScience#10010) [Django Upgrade] Upgrade django-elasticsearch-metrics (CenterForOpenScience#10021) [Django Upgrade] Fix one sub-query slicing issue (CenterForOpenScience#10012) Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes Only redirect to cas if not logged in OSFI: Update Shared SSO and Add MagLab/FSU [ENG-3654]
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 19, 2022
into update-README * 'develop' of https://github.com/CenterForOpenScience/osf.io: Bump version and update CHANGELOG [ENG-3854] Add management command to sync all DOI metadata (CenterForOpenScience#9972) Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) Update description for maglab [ENG-3249] Improve registration anonymization (CenterForOpenScience#10009) "backport" artifact changes and swap schema_response.justification (CenterForOpenScience#10003) Add new instn purdue Ensure BitBucket token is string, not bytes
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Sep 16, 2022
into remove-quickfiles * 'develop' of https://github.com/CenterForOpenScience/osf.io: (94 commits) Bump version and update CHANGELOG [ENG-3568] keen replacement (CenterForOpenScience#9954) Bump NR Agent version Fix typo Prevent errors in Keen-less environments Add missing defaults Bump DEFAULT_API_VERSION to 2.20 Improve import formatting Improve header comparison Add PLOS Metrics command - Update celery config/queues Fix local cookie samesite config and use 'Lax' instead of 'None' Add task to celery settings Pass and load Identifier ID instead of instance Bump version and update changelog Registration Resources (CenterForOpenScience#10042) Update test-build.yml Bump version and update CHANGELOG [ENG-3854] Add management command to sync all DOI metadata (CenterForOpenScience#9972) Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022) Update shield logo for colorado (UC Boulder) ... # Conflicts: # api_tests/base/test_sloan_study.py # osf/models/nodelog.py # osf/models/quickfiles.py # osf_tests/test_sanctions.py # package.json # tests/test_views.py # website/settings/defaults.py # website/static/js/anonymousLogActionsList.json # website/static/js/components/logFeed.js # website/static/js/logActionsList.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some subset of the fields removed from AVOLs in #10009 broke rendering of registrations in Ember. Add them back in so we can determine required FE steps at a later date
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket