Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for "can_request_access" feature #10877

Open
wants to merge 6 commits into
base: feature/institutional_access
Choose a base branch
from

Conversation

bodintsov
Copy link

@bodintsov bodintsov commented Dec 30, 2024

Purpose

Add to admin "can_request_access" option to the institution
API Changes for "can_request_access" feature

Done 2 tasks (ENG-6779) and (ENG-6780) within one PR, due to tickets being related to each other
Знімок екрана 2024-12-30 о 17 56 35

Changes

TBD

QA Notes

TBD

Documentation

TBD

Side Effects

TBD

Ticket

(https://openscience.atlassian.net/browse/ENG-6779)
(https://openscience.atlassian.net/browse/ENG-6780)

@bodintsov bodintsov marked this pull request as ready for review December 30, 2024 10:34
Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes so far look good with one small change, but we're missing the admin app functionality.

osf/models/institution.py Outdated Show resolved Hide resolved
@brianjgeiger
Copy link
Collaborator

Oh, and also tests need to be fixed.

@brianjgeiger
Copy link
Collaborator

While you're in there fixing tests, you might as well add some new ones to cover the new field.

@bodintsov
Copy link
Author

The changes so far look good with one small change, but we're missing the admin app functionality.

@brianjgeiger On the OSFadmin app, on the page of an institution, there is a possibility to change the can_request_access field. Maybe I missed something, and it needs to be done elsewhere?

@brianjgeiger
Copy link
Collaborator

On the OSFadmin app, on the page of an institution, there is a possibility to change the can_request_access field.

Oh, very good. Could take a screenshot and put it in the PR description, please?

@bodintsov
Copy link
Author

Oh, very good. Could take a screenshot and put it in the PR description, please?

Yes sure, I added a screenshot

@brianjgeiger
Copy link
Collaborator

@bodintsov Looks like tests are still failing.

Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions about an unexpected set of changes.

framework/email/tasks.py Outdated Show resolved Hide resolved
framework/email/tasks.py Outdated Show resolved Hide resolved
@Johnetordoff
Copy link
Contributor

@brianjgeiger @bodintsov is having some failing tests due to my changing of the sendgrid method, heres the fails on the feature branch https://github.com/CenterForOpenScience/osf.io/actions/runs/12380790854/job/34557929049?pr=10884. I told him to adjust the tests because that is working on staging.

@bodintsov
Copy link
Author

bodintsov commented Jan 4, 2025

I cant fix tests because the add_category method does not work. It is not assigning categories to the Mail object. Without fixing _send_with_sendgrid it is impossible to set proper tests.
Have also needed to add crutch to assert Email object to str.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants