-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for "can_request_access" feature #10877
base: feature/institutional_access
Are you sure you want to change the base?
Changes for "can_request_access" feature #10877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes so far look good with one small change, but we're missing the admin app functionality.
Oh, and also tests need to be fixed. |
While you're in there fixing tests, you might as well add some new ones to cover the new field. |
@brianjgeiger On the OSFadmin app, on the page of an institution, there is a possibility to change the |
Oh, very good. Could take a screenshot and put it in the PR description, please? |
Yes sure, I added a screenshot |
@bodintsov Looks like tests are still failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions about an unexpected set of changes.
@brianjgeiger @bodintsov is having some failing tests due to my changing of the sendgrid method, heres the fails on the feature branch https://github.com/CenterForOpenScience/osf.io/actions/runs/12380790854/job/34557929049?pr=10884. I told him to adjust the tests because that is working on staging. |
I cant fix tests because the |
Purpose
Add to admin "can_request_access" option to the institution
API Changes for "can_request_access" feature
Done 2 tasks (ENG-6779) and (ENG-6780) within one PR, due to tickets being related to each other
Changes
TBD
QA Notes
TBD
Documentation
TBD
Side Effects
TBD
Ticket
(https://openscience.atlassian.net/browse/ENG-6779)
(https://openscience.atlassian.net/browse/ENG-6780)