reduced number of requests to gv #10959
Open
+75
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opaduchak
force-pushed
the
fix/addon-query
branch
from
a83eebb to
5cc5d3e
Compare
adlius
reviewed
Feb 5, 2025
Comment on lines
+40
to
+51
| def get_external_services(requesting_user): | ||
| global _services | ||
| if _services: | ||
| return _services | ||
| _services = [] | ||
| for addon_type in gv_requests.AddonType: | ||
| srv = [EphemeralAddonConfig(service) for service in gv_requests.iterate_gv_results( | ||
| endpoint_url=gv_requests.ACCOUNT_EXTERNAL_SERVICE_ENDPOINT.format(addon_type=addon_type), | ||
| requesting_user=requesting_user, | ||
| )] | ||
| _services += srv | ||
| return _services |
There was a problem hiding this comment.
So the _services global variable here is an OSF-side cache for all the external services, correct? What's the lifetime of this cache? Does it exist for the lifetime of the WSGI app or for the lifetime of a single request?
| @@ -47,7 +53,7 @@ def get_account(gv_account_pk, requesting_user): # -> JSONAPIResultEntry | |||
| return get_gv_result( | |||
| endpoint_url=ACCOUNT_ENDPOINT.format(pk=gv_account_pk), | |||
| requesting_user=requesting_user, | |||
| params={'include': ACCOUNT_EXTERNAL_SERVICE_PATH}, | |||
| params={'include': ACCOUNT_EXTERNAL_STORAGE_SERVICE_PATH}, | |||
| ) | |||
There was a problem hiding this comment.
Do we even use this get_account hook anywhere? It seems to be only used previously in _get_addon_from_gv of the user model and that hook was removed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket