[ENG-1392] Backwards compatable Django upgrade to 2.0.13 #9300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the title
|
Looks good besides my one comment! |
brianjgeiger
approved these changes
Mar 18, 2020
Johnetordoff
force-pushed
the
django-upgrade-2.0.13-backwards-compat
branch
from
334216f to
4df457b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Get backwards compatible code out of the way before we flip over to Django 2
Changes
on_deletekwarg to foreign key fieldsdjango.urlsinstead ofdjango.core.urlresolverswhich is depreciatedQA Notes
Documentation
Tech task, no new docs.
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/ENG-1392