Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CORS for Django 3 #9982

Closed
wants to merge 10 commits into from

Conversation

Johnetordoff
Copy link
Contributor

Purpose

https://pypi.org/project/django-cors-headers/

Screen Shot 2022-07-17 at 4.02.19 PM.png## Changes

  • Updates Cors for Django 3 compatibility
  • changes requirement.txt to update CORS
  • refactors tests and settings
  • minor formating changes to provide CORS domains

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

Johnetordoff and others added 10 commits June 24, 2022 11:20
Use management command in post-migrate signal to create cache table instead of in Raw SQL in migrations
Co-authored-by: John Tordoff <>
* Create Waffle Flags and Switches as post_migrate_signal (with configurable values)
Co-authored-by: John Tordoff <>
* remove licenses from migration stream and only use post-migrate signal

Co-authored-by: John Tordoff <>
…ate signals (#9974)

* Set noop to all ensure_schema migrations
* Set noop to shema and shema block updates
* Add ensuring schema and updating schema blocks to post-migrate signals
* Set noop to one-time data migrations, which include
  * Preprint permissions
  * Schema to schema blocks
  * Draft node permissions
* Remove manual post-migration signals from PND
* Move generate_object_id into migration utils
* Replace duplicate function with inline imports
* Fix signal and clean-up
* don't use bulk create until ignore_conflicts exsists
* allow BLACKLISTED_DOMAINS to be seamlessly overridden

Co-authored-by: John Tordoff <>
)

* Move loading of citation styles to post-migration signal
* Peg repo to commit SHA
* Attempt to speed things up by loading fixture
* Move update_citation_styles to management command
* Remove old test like thing
* Clean up URL setting and docstring
* Remove install bower from CI setup
* Reorder imports
* Reintroduce tests, but test skip them
* Final clean-up

Co-authored-by: John Tordoff <>
Co-authored-by: Longze Chen <[email protected]>
* Remove storage region configuration from the migration stream and add to config file
* Only ensure default provider and remove yaml config
* Remove default storage region backfill
* Region gets or creates, but not updates
* Use _id and name as positional arguments and fix osf_settings

Co-authored-by: John Tordoff <>
Co-authored-by: Longze Chen <[email protected]>
@cslzchen cslzchen force-pushed the feature/django_upgrade branch from 65b0360 to 250b832 Compare July 27, 2022 19:20
@Johnetordoff Johnetordoff mentioned this pull request Aug 4, 2022
14 tasks
@Johnetordoff Johnetordoff marked this pull request as ready for review August 29, 2022 17:58
@mfraezz mfraezz deleted the upgrade-cors-django-3 branch October 21, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants