Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable draco quantization #10126

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Re-enable draco quantization #10126

merged 1 commit into from
Feb 22, 2022

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Feb 22, 2022

Fixes #9847

The only changes are to update the Draco version in package.json to 1.5.1 and to revert the changes to the decodeDraco worker from #9904.

As a note, this issue that appeared when we updated Draco does not look like it's fixed after these changes, so it's probably unrelated to quantization.

@ebogo1 ebogo1 requested a review from lilleyse February 22, 2022 22:12
@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@lilleyse
Copy link
Contributor

Looks good!

@lilleyse lilleyse merged commit ef4293b into main Feb 22, 2022
@lilleyse lilleyse deleted the enable-draco-quantization branch February 22, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable Draco quantization
3 participants