-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TerrainInspector app. #1017
Conversation
The race could makes tiles sometimes not show up as wireframe when they should.
I added a couple more features beyond what's shown in the screen shot. |
I suppose this is standalone (not in Sandcastle) because it's meant for development only? Does that also mean it should not be included in our release zip? I just want to make sure we are in agreement before I look to see what happens by default (I think it ends up included right now). |
Yes, that's why it's not in Sandcastle. I don't have a strong feeling one way or the other on including it in the release zip. I don't think it's needed, but it's small and possibly useful to a small set of users. |
"Show bounding sphere of selected tile" should probably enable "Suspend LOD update" otherwise it looks like the bounding sphere disappears and reappears. |
var centralBody = scene.getPrimitives().getCentralBody(); | ||
centralBody.depthTestAgainstTerrain = true; | ||
|
||
/*var mesh = new Cesium.CesiumMeshTerrainProvider({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this.
As discussed with @kring, we should rebrand this "Cesium Inspector" and make a reusable widget. #1025 has some initial ideas (not that any of them need to be in the scope of this pull request). As for the release, we should treat this like the other widgets. I am also OK with index.html linking to a trivial app that combines the viewer and inspector widgets. |
Wouldn't this be a perfect case for a |
Conflicts: Source/Scene/Tile.js
I like the idea of a widget / viewer mix-in, but I doubt I'm going to get to it anytime soon. Do we want this as-is for now (aside from some minor changes) or should we close the pull request? FWIW, I integrated this to the |
While I have no objection with this coming in as a standalone app to start, it currently ends up being part of the Cesium-full-bXX.zip, but non functional. I build the release zip and extracted it into an IIS subdirectory, but when I browsed to it it was looking for Source files in the wrong directory. It's possible this is related to buildModuleUrl, @shunter can you take a quick look? Another option would be to just exclude it from the zip for now. |
I'm also OK with this coming in as is (with the roadmap updated) once it is working in the release. |
Also, did you see my previous comment:
|
@@ -0,0 +1,126 @@ | |||
@import url(../../../Source/Widgets/widgets.css); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL is wrong. Should be ../../Source/
Yeah, but for my purposes it's better the way it is, I think. |
This is ready. The app in the full zip works now. |
Thanks for figuring out what was wrong, @shunter! |
I added it to the index.html and everything looks good now. If I have some spare time in the next couple of weeks, I'll look into widgetfying this. |
A simple application with a handful of features for debugging terrain.
This pull request also includes some minor changes to the underlying engine to support turning wireframe mode on and off dynamically.