Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed depthTestAgainstTerrain value being overridden when using the base layer picker widget #11412

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jul 10, 2023

Fixes #11393, given #6991

Until #6991 is addressed (which would be breaking behavior), I added a few unit tests to ensure it doesn't get broken.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense, and it fixes the Sandcastle in #11393. Thanks @ggetz!

@jjhembd jjhembd merged commit e658f01 into main Jul 12, 2023
@jjhembd jjhembd deleted the depth-test branch July 12, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With depthTestAgainstTerrain eq. true but Entity or Primitive are not covered by globe
3 participants