Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PR Template #11688

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Added PR Template #11688

merged 4 commits into from
Dec 12, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Dec 12, 2023

Description

We've gotten rid of the Cesium Concierge, who will no longer post handy comments like this.

While CLA checking is still in the works as part of a separate effort, this PR template aims to replace the functionality of that comment.

Issue number and link

Fixes #6167

Testing plan

I've used the template for this PR.
It will show up for PRs once merged into main.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change N/A
  • I have added or updated unit tests to ensure consistant code coverage N/A
  • I have update the inline documentation, and included code examples where relevant N/A
  • I have performed a self-review of my code

@ggetz ggetz requested a review from jjspace December 12, 2023 16:48
@ggetz
Copy link
Contributor Author

ggetz commented Dec 12, 2023

The CI failure is due to the latest update of our eslint rules. I'll open a separate PR to resolve it.

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple small comments.

It seems like the main two things losing Concierge lost was checking for a lack of changes in specific files. I feel like there should be solutions to do that same check in GHA if we wanted to instead of the checklist that could quickly start to get ignored? Just a thought

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@ggetz
Copy link
Contributor Author

ggetz commented Dec 12, 2023

It seems like the main two things losing Concierge lost was checking for a lack of changes in specific files. I feel like there should be solutions to do that same check in GHA if we wanted to instead of the checklist that could quickly start to get ignored? Just a thought

Good point. We might be able to do so with GitHub actions instead. I'll take a quick look. Either way, that can be a follow-up to this PR for the time being.

@ggetz
Copy link
Contributor Author

ggetz commented Dec 12, 2023

Thanks @jjspace! Updated.

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz LGTM!

@jjspace jjspace merged commit b5580fc into main Dec 12, 2023
5 checks passed
@jjspace jjspace deleted the pr-template branch December 12, 2023 19:55
@jjspace
Copy link
Contributor

jjspace commented Dec 12, 2023

@ggetz One downside to doing the confirmations with checkboxes is that GH considers them tasks and will include the completion count in a handful of places around the site. Might still be handy but it does add a bit of distraction/confusion especially if there is an "actual" tasklist in a PR

2023-12-12_16-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull request template
2 participants