-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PR Template #11688
Added PR Template #11688
Conversation
The CI failure is due to the latest update of our eslint rules. I'll open a separate PR to resolve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple small comments.
It seems like the main two things losing Concierge lost was checking for a lack of changes in specific files. I feel like there should be solutions to do that same check in GHA if we wanted to instead of the checklist that could quickly start to get ignored? Just a thought
Co-authored-by: Josh <[email protected]>
Good point. We might be able to do so with GitHub actions instead. I'll take a quick look. Either way, that can be a follow-up to this PR for the time being. |
Thanks @jjspace! Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ggetz LGTM!
@ggetz One downside to doing the confirmations with checkboxes is that GH considers them tasks and will include the completion count in a handful of places around the site. Might still be handy but it does add a bit of distraction/confusion especially if there is an "actual" tasklist in a PR |
Description
We've gotten rid of the Cesium Concierge, who will no longer post handy comments like this.
While CLA checking is still in the works as part of a separate effort, this PR template aims to replace the functionality of that comment.
Issue number and link
Fixes #6167
Testing plan
I've used the template for this PR.
It will show up for PRs once merged into
main
.Author checklist
CONTRIBUTORS.md
I have updatedN/ACHANGES.md
with a short summary of my changeI have added or updated unit tests to ensure consistant code coverageN/AI have update the inline documentation, and included code examples where relevantN/A