Geometry not always obeying Entity.show #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Geometry created by the Entity API was defaulting its show attribute to true, even when `entity.show` was false. 2. When new Entity geometry was added to an existing batch, the current show attribute was not properly migrated from the old Primitive instance to the new one.
|
Looks good. |
pjcozzi
added a commit
that referenced
this pull request
May 28, 2015
Geometry not always obeying Entity.show
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues. First is the simple case where
Entity.showis set to false at the time entity geometry gets created but the geometry would still show up (because none of the geometry updaters were checking forentity.isShowingat creation time. Second was the current value of geometry attributes being lost when entities were re-batched when new geometry was added. This is because the instance attributes in the original geometry are not the same instance as the attributes on the created primitive. Now we loop through current attribute values and transfer them to the new primitive.In addition to new tests, there' s also a Sandcastle example in #2686 that can reproduce the problem.
Fixes #2686