Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TileBoundingBox #5150

Merged
merged 8 commits into from
Mar 28, 2017
Merged

Fix TileBoundingBox #5150

merged 8 commits into from
Mar 28, 2017

Conversation

duvifn
Copy link
Contributor

@duvifn duvifn commented Mar 27, 2017

Fixes #4032.

See #4032 (comment).

This PR changes the way that the south plane is computed on the northern hemisphere (same for the north plane on the southern hemisphere).

Before:

before_hopefully_final

After:

after_hopefully_final

I didn't check if this also fixes other issues.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 27, 2017

Thanks for the detective work and fix, @duvifn, it is much appreciated!

@kring do you have any cycles to look at this?

@kring
Copy link
Member

kring commented Mar 28, 2017

Looks good to me, thanks @duvifn!

@kring kring merged commit 71c624e into CesiumGS:master Mar 28, 2017
@duvifn
Copy link
Contributor Author

duvifn commented Mar 28, 2017

Thanks @pjcozzi and @kring for the quick treatment.
I really appreciate it!

@duvifn
Copy link
Contributor Author

duvifn commented Mar 28, 2017

Just a little comment:
I added this fix to the top of CHANGES.md because I didn't know which version it would be shipped with.
Can you fix it in master?

@kring
Copy link
Member

kring commented Mar 28, 2017

Yep, already did. Thanks for the reminder though, I did almost managed to forget about it!

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 28, 2017

Thanks for the quick review, @kring. I will get to #5051 soon...this week, really.

@duvifn duvifn deleted the fix_tileBoundingBox2 branch March 29, 2017 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black terrain artifact
3 participants