Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyc styling demo #5527

Closed
wants to merge 2 commits into from
Closed

Conversation

rahwang
Copy link
Contributor

@rahwang rahwang commented Jun 22, 2017

Hey @lilleyse , how's this? I'll add a thumbnail tomorrow.

@lilleyse
Copy link
Contributor

lilleyse commented Jun 22, 2017

At first glance there are too many styling sliders and it isn't immediately clear how the styling is related to the metadata. I would aim to follow the original demo more closely with coloring by height, hiding by height, and color palettes.

But there is also room to explore. Each building contains area, longitude, and latitude properties which can be used to create completely different types of styles. At least for me, variety is the key for this Sandcastle.

@rahwang
Copy link
Contributor Author

rahwang commented Jun 22, 2017

The sliders are just to control the color palette -- I can definitely trim them down to perhaps one per color channel unless you think I should just limit the color palettes to some pre-defined oNES.

As for variety, I was a bit hesitant about making this example too long, like the other one. Do you think it's worth having examples for coloring by height as well as say area? Because those will differ only really in ${height} vs ${area}

@lilleyse
Copy link
Contributor

I think some predefined color gradients is the simplest way to go. The binning approach from the original demo could be dropped as well so that the style is simpler.

A style that colors by area is actually kind of nice because it contrasts with styling by height. Other style ideas might be:

  • Only show buildings whose area is greater than height
  • Color by volume
  • Color by distance from some landmark using longitude and latitude and the distance function
  • Something abstract using tiles3d_tileset_time maybe?

@rahwang rahwang closed this Jun 26, 2017
@rahwang rahwang deleted the 3d-tiles-styling-demo branch June 26, 2017 13:01
@rahwang rahwang mentioned this pull request Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants