Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Tiles Sandcastle Demos #5578

Merged
merged 11 commits into from
Jul 5, 2017
Merged

3D Tiles Sandcastle Demos #5578

merged 11 commits into from
Jul 5, 2017

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jul 3, 2017 •
edited
Loading

Fixes #5506

Demos (the first 5 are also in the main Showcases tab):

  • 3D Tiles BIM (Power Plant model from Bentley)
  • 3D Tiles Point Cloud (Chappes Church)
  • 3D Tiles Photogrammetry (AGI building)
    • Some artifacts when skipLevelOfDetail is on due to thin roof walls
  • 3D Tiles Feature Picking (NYC CityGML)
  • 3D Tiles Feature Styling (NYC CityGML)
  • 3D Tiles Adjust Height (commonly requested code sample on the forum)
  • 3D Tiles Batch Table Hierarchy
  • 3D Tiles Formats (a simplified version of the original 3D Tiles demo)
  • 3D Tiles Inspector
  • 3D Tiles Interactivity (annotations, print metadata, zoom to, hide feature abilities from the original 3D Tiles demo)
  • 3D Tiles Point Cloud Styling

To do:

  • Demos still need attribution. Is a sentence at the top of the demo code sufficient?
  • Tilesets are currently hosted on my personal Composer account.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 4, 2017

Demos still need attribution. Is a sentence at the top of the demo code sufficient?

Yes, later these may be embedded in the tileset, CesiumGS/3d-tiles#55

Tilesets are currently hosted on my personal Composer account.

Please address this soon so it doesn't delay the 1.35 release tomorrow. If we can't address this by about noon, we'll ship with these urls and update in the next release.

pjcozzi
pjcozzi requested changes Jul 4, 2017
View reviewed changes
Apps/Sandcastle/gallery/3D Tiles BIM.html Outdated
//Sandcastle_Begin
var viewer = new Cesium.Viewer('cesiumContainer');

var tileset = viewer.scene.primitives.add(new Cesium.Cesium3DTileset({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps don't put this one in a body of water?

Apps/Sandcastle/gallery/3D Tiles Point Cloud.html Outdated
var viewer = new Cesium.Viewer('cesiumContainer');

var tileset = viewer.scene.primitives.add(new Cesium.Cesium3DTileset({
url : 'https://beta.cesium.com/api/assets/1448?access_token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiJiODNmMjQzNy1mNGI4LTQ2ZTItOWI0NS0yZDUzMzMyNWMxNzQiLCJpZCI6OSwiaWF0IjoxNDgxODI5ODU0fQ.4fmVtksZ1CAzjPBprJ47uIuK0vr-8CcuDKM7M8a0mF4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnimatedRNG this is another good point cloud dataset for your testing.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 4, 2017

Also please add an indoor example like the San Miguel. Perhaps @likangning93 can help.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 5, 2017

Updated CHANGES.md in master for this. 3340d14

@lilleyse
Copy link
Contributor Author

lilleyse commented Jul 5, 2017

Updated.

Also please add an indoor example like the San Miguel

After talking with @likangning93 we don't actually have similar ones that are free for us to use, besides models that are too small to be worth tiling like Sponza or the Cathedral.

@lilleyse
Copy link
Contributor Author

lilleyse commented Jul 5, 2017

Ready with the San Miguel model under the 3D Tiles Interior name. Thanks for tiling it @likangning93.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 5, 2017

Looks great!

@pjcozzi pjcozzi merged commit 5838c6f into master Jul 5, 2017
@pjcozzi pjcozzi deleted the 3d-tiles-demos branch July 5, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjcozzi pjcozzi pjcozzi requested changes

Assignees
No one assigned
Labels
priority - next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilleyse @pjcozzi @rahwang