Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8006 Fix incorrect billboard clamping when terrain provider changes #9079

Closed
wants to merge 5 commits into from
Closed

#8006 Fix incorrect billboard clamping when terrain provider changes #9079

wants to merge 5 commits into from

Commits on Aug 3, 2020

  1. CesiumGS#8006 Pass id of billboard to callback function to prevent mu… 

    …ltiple callbacks being registered for the same billboard in invalidateAllTiles, resulting in leaked/stale callbacks and bad clamped locations.
    @bn-dignitas
    bn-dignitas committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    0ba8738 View commit details
    Browse the repository at this point in the history

  2. Make sure callbacks with undefined owner are added to maintain behavi… 

    …or for other primitive types
    @bn-dignitas
    bn-dignitas committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    8bf60cc View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Fix billboard position issues when reused billboard height ref is cha… 

    …nged from clamped to none
    @bn-dignitas
    bn-dignitas committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    749f7a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Store the billboard instead of the ID since billboards are reused and… 

    … IDs change
    @bn-dignitas
    bn-dignitas committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    922488b View commit details
    Browse the repository at this point in the history

  2. Fix object type in documentation

    @bn-dignitas
    bn-dignitas committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    e7497a7 View commit details
    Browse the repository at this point in the history