-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add procedurally-generated billboard clouds #9737
Conversation
Thanks for the pull request @j9liu!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j9liu great job on this! The approach you went with strikes the right balance of ease of use and flexibility for advanced users. Excellent doc and unit tests like usual. Mostly minor feedback from me on the code side.
While it would be great to have fully procedural, volumetric clouds in the future this is a great start. I'm looking forward to your roadmap issue.
Some more meta feedback - now that I've reviewed the code I think
Given the extent of these changes the current approach still makes sense, but if we want to consolidate in the future I think we can. |
@lilleyse - just made some changes, let me know what you think! |
This PR implements the cloud enhancement as outlined in #9691, including the following features.
CumulusCloud
class andCloudCollection
API, with a similar interface toBillboardCollection
CumulusCloud
andCloudCollection
that the user can tweak to vary the appearance of their cloudsThis is still a work in progress. Remaining tasks:CumulusCloud
andCloudCollection
documentation.