Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Node 16 for CI #9858

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Switch to Node 16 for CI #9858

merged 3 commits into from
Oct 11, 2021

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Oct 8, 2021

Node 16 will be LTS on 2021-10-26 so we need to ensure it's passing and works.

We might want to consider testing against multiple Node versions down the line, but using the latest LTS has worked well so far (though apparently we skipped 14 completely here)

I expect this branch to fail until fixes we know are needed for Node 16 get merged.

CC @ebogo1

Node 16 will be LTS on `2021-10-26` so we need to ensure it's passing and
works.

We might want to consider testing against multiple Node versions down the
line, but using the latest LTS has worked well so far (though apparnetly
we skipped 14 completely here)
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

CI is passing now that #9861 was merged. Thanks @mramato.

@lilleyse lilleyse merged commit f95eb47 into main Oct 11, 2021
@lilleyse lilleyse deleted the node-16 branch October 11, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants