Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Draco quantization workaround for point clouds #9908

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Nov 1, 2021

This fixes a regression from 1.86 after updating Draco, where SkipAttributeTransform broke future attribute lookups with GetAttributeByUniqueId. To reproduce, see this Sandcastle and select the "PointCloudDraco" tileset.

This change is analogous to #9904, but since decodePointCloud always tries to call SkipAttributeTransform on "POSITION" and "NORMAL", those are the two attributes that use GetAttributeId and GetAttribute instead of GetAttributeByUniqueId.

@ebogo1 ebogo1 requested a review from lilleyse November 1, 2021 16:41
@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@lilleyse
Copy link
Contributor

lilleyse commented Nov 1, 2021

@ebogo1 looks good. At one point you mentioned that there was a point cloud draco test that had been removed in #9841 that was still failing. Is that still the case, or can we add it back now?

@ebogo1
Copy link
Contributor Author

ebogo1 commented Nov 1, 2021

@lilleyse Good catch - I added the tests back in 6c55ad1.

@lilleyse lilleyse merged commit 67e2bf7 into main Nov 1, 2021
@lilleyse lilleyse deleted the draco-point-fix branch November 1, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants