-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge CAIP69 into CAIP10 for specifying EOA wallets #107
feat: merge CAIP69 into CAIP10 for specifying EOA wallets #107
Conversation
Co-authored-by: Bumblefudge <[email protected]>
Co-authored-by: Bumblefudge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending final feedback review for @jainkrati
Co-authored-by: Bumblefudge <[email protected]>
re-requesting review from @bumblefudge to confirm if changes look good and I did not miss any review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, almost done here, just noticed a TODO and a header change and a regex change. Apologies for the inefficiency!
Co-authored-by: Bumblefudge <[email protected]>
Co-authored-by: Bumblefudge <[email protected]>
Co-authored-by: Bumblefudge <[email protected]>
I'm really not a fan of this, namely this adds a weird edge case that is non-specific to the naming convention of I'd suggest the following:
We can still maintain backward compatibility by doing a simple check:
We can then verify if this account is EOA or SCW by doing the following checks: |
by "append a new [segment] to the string" do you mean breaking CAIP-10? non-EVM devs might consider ethereum's evolving concept of an account the weird edge case, in that the EOA/SCA distinction is entirely specific to EVM wallet interfaces (I can't think of any other namespace that would use this new segment). What I'm getting at is that if we added a segment to all CAIP-10s, every non-EVM CAIP-10 would A.) break, and B.) have to insert, going forward, a in defense of the original proposal, I don't think this edge case is so weird in the EVM tradition-- it continues the tradition of the The way I see it, 1/2/3 is already status quo, or to put it another way, what you describe as the verification step in the future where CAIP-10s mark accounts by type is today's clunky discovery step for lack of any such type discovery. Both the original proposal and your "additional segment" counterproposal both add a declarative standard notation for what, today, is guessed at or deduced at the last minute. My argument is that 2 and 3 ARE chain-specific and 1 is specifically chain-independent/offchain, and I feel like future types (the values other than 0 and 1 in your proposal) will all be either chain-specific or off-chain, so i'm not sure we need to hold space for future wallet-typing. If anything, typing of wallets is a legacy problem, and the "let's phase out EOAs forever" crowd would probably like us to sunset the special case of EOAs and move to an entirely abstracted future in which there is no need to type (or sniff) wallets... |
@GregTheGreek I hope that didn't come across as dismissive, just trying to read you in on the history of CAIP-10 design (and implementation) before this PR and explain why the odds are so stacked against a new segment. Does this new information address your qualms? Would merging this make you less likely to use or trust CAIP-10s in future multichain/cross-chain projects? Can you think of other alternatives that might be more palatable to CAIP-10's existing users and downstream projects? @jainkrati @GriffGreen are you guys happy with the new version? feel free to roll back individual edits or push back, i'm just an editor here. Sorry to slow things down, I was just trying to factor in a few corner-cases I know of from other implementers. I talked to Obstropolous out-of-band (well, at a public meeting of the CASA editorial WG) and I don't think his approval needs to be staled/rerequested, he workshopped my edits and is happy either way as long as nothing normative/major changes in further edits. he's pretty deep in implementation on the topic from Spruce days, after all. |
Co-authored-by: Bumblefudge <[email protected]>
Thanks @bumblefudge ! Really appreciate your help here for progressing this PR |
OK I'd say that's affirmative consent enough to merge, but DO feel free to tag each other and any other stakeholder you think would have useful feedback in follow-on PRs if you still have misgivings or if new counter-proposals or extensions come to mind over time, @GregTheGreek and @GriffGreen ! |
The goal of this PR is to empower CAIP 10 to specify EOA across EVM Chains with chainID of 0.
We raised a PR for this earlier in CAIP repo ChainAgnostic/CAIPs#268 and based on review comments/suggestions, we are raising this PR.