-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: forest binary reorg #216
Conversation
@LesnyRumcajs Can you check the TF part as well? |
@elmattic have you tested these changes making sure they are working as intended ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Port changes can be a separate PR. We can expose 1234 and 2345 so they work with binaries before and after the default port change.
- That said, it won't give much as long as the commands are not backwards compatible, i.e., if there's no
forest-tool db destroy
in the current version, it will just fail miserably.
We need to either:
- ensure both versions (current one and unreleased containing reorg changes) work fine - this requires having logic for handling this, either in Forest (e.g.,
forest-cli db clean
would forward the call toforest-tool db destroy
) or in here (check Forest version and use correct set of commands based on that. This may be an overkill. - Merge the changes from this PR only after a version has been released. This approach invalidates exposing both 1234 and 2345, as there would be only one "true" version.
Sync check changes would need to be in a separate PR and follow the same logic - either merge as soon as reorg is merged in Forest or have a compatibility layer.
How exactly ? Do we have some documentation for this ? |
Yes, you're able to manually execute test samples for various services. The steps for each can be found within their respective folders in the Terraform directory. |
That's a bit misleading. The steps there are not intended for manual testing and should not be performed on branches. Otherwise, all the prod services will get terraformed. Would be great to have a more detailed instructions on testing for future reference. |
True i missed that, i will write a more detailed documentation on that |
Forest: Lotus Mainnet Infrastructure Plan: successShow Plan
|
Forest: Snapshot Service Infrastructure Plan: successShow Plan
|
Forest: Lotus Mainnet Infrastructure Plan: successShow Plan
|
Forest: Mainnet Infrastructure Plan: successShow Plan
|
Signed-off-by: samuelarogbonlo <[email protected]>
Forest: Calibnet Infrastructure Plan: successShow Plan
|
Forest: Snapshot Service Infrastructure Plan: successShow Plan
|
@LesnyRumcajs can you dismiss your stale review here also ? |
Forest: Calibnet Infrastructure Plan: successShow Plan
|
Forest: Mainnet Infrastructure Plan: successShow Plan
|
Forest: Mainnet Infrastructure Plan: successShow Plan
|
Forest: Lotus Mainnet Infrastructure Plan: successShow Plan
|
Forest: Mainnet Infrastructure Plan: successShow Plan
|
Summary of changes
Changes introduced in this pull request:
forest-cli db
subcommands migration forest#3355forest-cli wallet
subcommands migration forest#3362Note that some PR have been already merged.
Reference issue to close (if applicable)
Closes
Other information and links