[Refactor] Benchmark script error handling improvements #228

jdjaustin · 2023-08-23T11:48:35Z

Summary of changes
Changes introduced in this pull request:

Implement improvements to error handling. Create a common error handler and use this error handler where possible; also propagate detailed errors.

Reference issue to close (if applicable)

Closes associated tasks in #137

Other information and links

Based off of changes in #122; will wait for that PR to merge before merging this PR.

github-actions · 2023-08-23T11:49:01Z

Forest: Benchmark Service Infrastructure Plan: success

Show Plan

module.benchmark.data.local_file.init: Reading...
module.benchmark.data.external.sources_tar: Reading...
module.benchmark.data.local_file.init: Read complete after 0s [id=6219c2dc51a104ab56e8b28453fca9608e3ae76d]
module.benchmark.data.external.sources_tar: Read complete after 0s [id=-]
module.benchmark.data.digitalocean_project.forest_project: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Reading...
module.benchmark.data.local_file.sources: Reading...
module.benchmark.data.local_file.sources: Read complete after 0s [id=1ecfb5f132ed96ab1d1ebdb85dc0cbe51609aa09]
module.benchmark.data.digitalocean_ssh_keys.keys: Read complete after 1s [id=ssh_keys/4003270040538543685]
module.benchmark.digitalocean_droplet.forest: Refreshing state... [id=371325559]
module.benchmark.data.digitalocean_project.forest_project: Read complete after 2s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.benchmark.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.benchmark.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-08-23T11:34:01Z" -> (known after apply)
      ~ disk                 = 300 -> (known after apply)
      ~ id                   = "371325559" -> (known after apply)
      ~ ipv4_address         = "46.101.175.228" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.8" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
        name                 = "forest-benchmark"
      ~ price_hourly         = 0.19494 -> (known after apply)
      ~ price_monthly        = 131 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:371325559" -> (known after apply)
      ~ user_data            = "c22b994b41050a51f96f7f112ca8a429d0483ae9" -> "5f31fd284c25707e09f05ba2a1f7c31432f3966a" # forces replacement
      ~ vcpus                = 2 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (9 unchanged attributes hidden)
    }

  # module.benchmark.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:371325559",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "46.101.175.228",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

…mprovements

github-actions · 2023-08-23T11:55:34Z

Forest: Benchmark Service Infrastructure Plan: success

Show Plan

module.benchmark.data.external.sources_tar: Reading...
module.benchmark.data.local_file.init: Reading...
module.benchmark.data.local_file.init: Read complete after 0s [id=8a79718ce589edec7ac0c28bf0856a5b355e7588]
module.benchmark.data.external.sources_tar: Read complete after 0s [id=-]
module.benchmark.data.local_file.sources: Reading...
module.benchmark.data.digitalocean_project.forest_project: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Reading...
module.benchmark.data.local_file.sources: Read complete after 0s [id=f2b28a7939f9d272788354e52e037b3f07cceebb]
module.benchmark.data.digitalocean_ssh_keys.keys: Read complete after 1s [id=ssh_keys/4003270040538543685]
module.benchmark.digitalocean_droplet.forest: Refreshing state... [id=371325559]
module.benchmark.data.digitalocean_project.forest_project: Read complete after 2s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.benchmark.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.benchmark.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-08-23T11:34:01Z" -> (known after apply)
      ~ disk                 = 300 -> (known after apply)
      ~ id                   = "371325559" -> (known after apply)
      ~ ipv4_address         = "46.101.175.228" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.8" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
        name                 = "forest-benchmark"
      ~ price_hourly         = 0.19494 -> (known after apply)
      ~ price_monthly        = 131 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:371325559" -> (known after apply)
      ~ user_data            = "c22b994b41050a51f96f7f112ca8a429d0483ae9" -> "75520d76f4a63b7bdfd4008b795cb1c5e84a90dd" # forces replacement
      ~ vcpus                = 2 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (9 unchanged attributes hidden)
    }

  # module.benchmark.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:371325559",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "46.101.175.228",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

github-actions · 2023-08-23T16:18:50Z

Forest: Benchmark Service Infrastructure Plan: success

Show Plan

module.benchmark.data.local_file.init: Reading...
module.benchmark.data.local_file.init: Read complete after 0s [id=8a79718ce589edec7ac0c28bf0856a5b355e7588]
module.benchmark.data.external.sources_tar: Reading...
module.benchmark.data.external.sources_tar: Read complete after 0s [id=-]
module.benchmark.data.local_file.sources: Reading...
module.benchmark.data.local_file.sources: Read complete after 0s [id=02333466a30500273191ac8669017c8be08df7a3]
module.benchmark.data.digitalocean_project.forest_project: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Read complete after 0s [id=ssh_keys/4003270040538543685]
module.benchmark.digitalocean_droplet.forest: Refreshing state... [id=371350759]
module.benchmark.data.digitalocean_project.forest_project: Read complete after 1s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.benchmark.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.benchmark.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-08-23T14:55:46Z" -> (known after apply)
      ~ disk                 = 300 -> (known after apply)
      ~ id                   = "371350759" -> (known after apply)
      ~ ipv4_address         = "46.101.199.188" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.8" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
        name                 = "forest-benchmark"
      ~ price_hourly         = 0.19494 -> (known after apply)
      ~ price_monthly        = 131 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:371350759" -> (known after apply)
      ~ user_data            = "157ece5631bac2c5f6b34481cb2c06f066160f4a" -> "d8113d554c16ffd940f60a8a29e158aa056dfea7" # forces replacement
      ~ vcpus                = 2 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (9 unchanged attributes hidden)
    }

  # module.benchmark.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:371350759",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "46.101.199.188",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

github-actions · 2023-08-23T16:26:20Z

Forest: Benchmark Service Infrastructure Plan: success

Show Plan

module.benchmark.data.local_file.init: Reading...
module.benchmark.data.local_file.init: Read complete after 0s [id=8a79718ce589edec7ac0c28bf0856a5b355e7588]
module.benchmark.data.external.sources_tar: Reading...
module.benchmark.data.external.sources_tar: Read complete after 0s [id=-]
module.benchmark.data.local_file.sources: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Reading...
module.benchmark.data.local_file.sources: Read complete after 0s [id=3b63760e093ea176de1a57a512a9aaedf20dd151]
module.benchmark.data.digitalocean_project.forest_project: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Read complete after 1s [id=ssh_keys/4003270040538543685]
module.benchmark.digitalocean_droplet.forest: Refreshing state... [id=371350759]
module.benchmark.data.digitalocean_project.forest_project: Read complete after 2s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.benchmark.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.benchmark.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-08-23T14:55:46Z" -> (known after apply)
      ~ disk                 = 300 -> (known after apply)
      ~ id                   = "371350759" -> (known after apply)
      ~ ipv4_address         = "46.101.199.188" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.8" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
        name                 = "forest-benchmark"
      ~ price_hourly         = 0.19494 -> (known after apply)
      ~ price_monthly        = 131 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:371350759" -> (known after apply)
      ~ user_data            = "157ece5631bac2c5f6b34481cb2c06f066160f4a" -> "62943c86deab207b93f67962e90445b7f77b4e18" # forces replacement
      ~ vcpus                = 2 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (9 unchanged attributes hidden)
    }

  # module.benchmark.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:371350759",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "46.101.199.188",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

github-actions · 2023-09-08T09:45:13Z

Forest: Benchmark Service Infrastructure Plan: success

Show Plan

module.benchmark.data.local_file.init: Reading...
module.benchmark.data.external.sources_tar: Reading...
module.benchmark.data.local_file.init: Read complete after 0s [id=ac01021d6b8feecbfdfa37d417c8da525ee65b1a]
module.benchmark.data.external.sources_tar: Read complete after 0s [id=-]
module.benchmark.data.local_file.sources: Reading...
module.benchmark.data.local_file.sources: Read complete after 0s [id=d3009db762de976a1c5ec7d7f3653dd084a08220]
module.benchmark.data.digitalocean_ssh_keys.keys: Reading...
module.benchmark.data.digitalocean_project.forest_project: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Read complete after 1s [id=ssh_keys/4003270040538543685]
module.benchmark.digitalocean_droplet.forest: Refreshing state... [id=373629673]
module.benchmark.data.digitalocean_project.forest_project: Read complete after 2s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.benchmark.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.benchmark.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-09-07T14:56:06Z" -> (known after apply)
      ~ disk                 = 300 -> (known after apply)
      ~ id                   = "373629673" -> (known after apply)
      ~ ipv4_address         = "165.22.89.58" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.7" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
        name                 = "forest-benchmark"
      ~ price_hourly         = 0.19494 -> (known after apply)
      ~ price_monthly        = 131 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:373629673" -> (known after apply)
      ~ user_data            = "68827a05d74067999e6c11cf40a162ff5228e2e2" -> "f29b19c894f81ec59339d3d9e2d4a014309b4b84" # forces replacement
      ~ vcpus                = 2 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (9 unchanged attributes hidden)
    }

  # module.benchmark.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:373629673",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "165.22.89.58",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

terraform/modules/benchmark/service/bench.rb

terraform/modules/benchmark/service/benchmark_base.rb

github-actions · 2023-09-12T14:11:53Z

Forest: Benchmark Service Infrastructure Plan: success

Show Plan

module.benchmark.data.external.sources_tar: Reading...
module.benchmark.data.local_file.init: Reading...
module.benchmark.data.local_file.init: Read complete after 0s [id=ac01021d6b8feecbfdfa37d417c8da525ee65b1a]
module.benchmark.data.digitalocean_ssh_keys.keys: Reading...
module.benchmark.data.digitalocean_project.forest_project: Reading...
module.benchmark.data.external.sources_tar: Read complete after 0s [id=-]
module.benchmark.data.local_file.sources: Reading...
module.benchmark.data.local_file.sources: Read complete after 0s [id=c36b85bda06571321afe9e9d27609b4538fe56da]
module.benchmark.data.digitalocean_ssh_keys.keys: Read complete after 0s [id=ssh_keys/7554529413782672922]
module.benchmark.digitalocean_droplet.forest: Refreshing state... [id=373629673]
module.benchmark.data.digitalocean_project.forest_project: Read complete after 1s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.benchmark.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.benchmark.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-09-07T14:56:06Z" -> (known after apply)
      ~ disk                 = 300 -> (known after apply)
      ~ id                   = "373629673" -> (known after apply)
      ~ ipv4_address         = "165.22.89.58" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.7" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
        name                 = "forest-benchmark"
      ~ price_hourly         = 0.19494 -> (known after apply)
      ~ price_monthly        = 131 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ ssh_keys             = [ # forces replacement
          - "9d:f6:f8:05:f7:c2:72:a2:b7:ce:f8:3e:71:12:2e:09",
            # (19 unchanged elements hidden)
        ]
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:373629673" -> (known after apply)
      ~ user_data            = "68827a05d74067999e6c11cf40a162ff5228e2e2" -> "8d1ba33495b31a254b7cbca2b8c09db6ec8d64e4" # forces replacement
      ~ vcpus                = 2 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (8 unchanged attributes hidden)
    }

  # module.benchmark.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:373629673",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "165.22.89.58",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

github-actions · 2023-09-19T13:27:15Z

Forest: Benchmark Service Infrastructure Plan: success

Show Plan

module.benchmark.data.external.sources_tar: Reading...
module.benchmark.data.local_file.init: Reading...
module.benchmark.data.local_file.init: Read complete after 0s [id=315e8950bc9b460e17e1458b953f37a15f7b1d45]
module.benchmark.data.external.sources_tar: Read complete after 0s [id=-]
module.benchmark.data.digitalocean_project.forest_project: Reading...
module.benchmark.data.local_file.sources: Reading...
module.benchmark.data.digitalocean_ssh_keys.keys: Reading...
module.benchmark.data.local_file.sources: Read complete after 0s [id=29334053af01eb641d7c76954e26751bb7fefc23]
module.benchmark.data.digitalocean_ssh_keys.keys: Read complete after 1s [id=ssh_keys/14512061520513425405]
module.benchmark.digitalocean_droplet.forest: Refreshing state... [id=375473525]
module.benchmark.data.digitalocean_project.forest_project: Read complete after 2s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.benchmark.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.benchmark.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-09-19T13:19:25Z" -> (known after apply)
      ~ disk                 = 300 -> (known after apply)
      ~ id                   = "375473525" -> (known after apply)
      ~ ipv4_address         = "138.68.101.242" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.7" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
      ~ name                 = "forest-guillaume-benchmark" -> "forest-benchmark"
      ~ price_hourly         = 0.19494 -> (known after apply)
      ~ price_monthly        = 131 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:375473525" -> (known after apply)
      ~ user_data            = "159f87f9b5850c1b58348a9b732dcb9fb2a09f8c" -> "a70ef34e45a1f8b5706f59e7eee0754e3db8e90d" # forces replacement
      ~ vcpus                = 2 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (9 unchanged attributes hidden)
    }

  # module.benchmark.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:375473525",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "138.68.101.242",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

sudo-shashank and others added 30 commits June 14, 2023 12:05

Added benchmark db terraform service

a3bd3dc

Merge branch 'main' into benchmark-db

c7c69d8

upload result

8f24d5b

add slack notification

80d7cb6

Merge branch 'main' into benchmark-db

dc28890

store benchmark results

5e7f226

add error alerts

eed612c

use docker container

83696e2

remove extra .gitignore

656900d

fmt

54a5af0

Added deploy denchmark db

e1944e1

Merge branch 'main' into benchmark-db

946125f

schedule the workflow to be executed at midnight everyday

7783cc9

Use lotus master for mainnet

4f6a0b6

use new forest benchmark storage

152b8b8

add metric in output

1cd9351

Changed benchmark result format

4db2758

Merge branch 'main' into benchmark-db

05601ce

updated workflow to deploy benchmark service

f1e82b8

Added more comments

e646146

Merge branch 'main' into benchmark-db

4e9cc64

Merge branch 'main' into benchmark-db

8764e29

fmt

56dfb9c

add comments and remove unused env var

642979e

use actual slack channel

c72da9b

fmt

02200a6

fmt

aec1dc6

Merge branch 'main' into benchmark-db

5b7d229

Removed terraform destroy trigger

27341e7

setup cron job

37c518d

sudo-shashank and others added 4 commits August 23, 2023 14:01

fix fetch params

73f010b

Remove docker installation

e0a5bf8

refactor: additional error handling changes

6b59a5c

Merge branch 'main' into benchmark-db

3bdb2fb

Merge branch 'benchmark-db' into jdjaustin/issue-137-error-handling-i…

40a9532

…mprovements

jdjaustin changed the title ~~[Refactor] Error handling improvements~~ [Refactor] Benchmark script error handling improvements Aug 23, 2023

fix: err handling for metrics, add/modify cleanup fn

f278e44

fix: rm commented out Forest bench

55eaece

Merge branch 'main' into jdjaustin/issue-137-error-handling-improvements

c6228ef

jdjaustin marked this pull request as ready for review September 8, 2023 11:21

jdjaustin requested a review from a team as a code owner September 8, 2023 11:21

jdjaustin requested review from elmattic and aatifsyed and removed request for a team September 8, 2023 11:21

elmattic reviewed Sep 12, 2023

View reviewed changes

terraform/modules/benchmark/service/bench.rb Outdated Show resolved Hide resolved

terraform/modules/benchmark/service/benchmark_base.rb Show resolved Hide resolved

terraform/modules/benchmark/service/benchmark_base.rb Show resolved Hide resolved

style: suggestion from code review

202c80a

aatifsyed approved these changes Sep 19, 2023

View reviewed changes

jdjaustin enabled auto-merge (squash) September 19, 2023 13:21

Merge branch 'main' into jdjaustin/issue-137-error-handling-improvements

abbec5f

jdjaustin disabled auto-merge September 19, 2023 13:22

jdjaustin enabled auto-merge (squash) September 19, 2023 13:22

jdjaustin merged commit 8b2cc4d into main Sep 19, 2023
8 checks passed

jdjaustin deleted the jdjaustin/issue-137-error-handling-improvements branch September 19, 2023 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactor] Benchmark script error handling improvements #228

[Refactor] Benchmark script error handling improvements #228

jdjaustin commented Aug 23, 2023 •

edited

Loading

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Sep 8, 2023

github-actions bot commented Sep 12, 2023

github-actions bot commented Sep 19, 2023

[Refactor] Benchmark script error handling improvements #228

[Refactor] Benchmark script error handling improvements #228

Conversation

jdjaustin commented Aug 23, 2023 • edited Loading

github-actions bot commented Aug 23, 2023

Forest: Benchmark Service Infrastructure Plan: success

github-actions bot commented Aug 23, 2023

Forest: Benchmark Service Infrastructure Plan: success

github-actions bot commented Aug 23, 2023

Forest: Benchmark Service Infrastructure Plan: success

github-actions bot commented Aug 23, 2023

Forest: Benchmark Service Infrastructure Plan: success

github-actions bot commented Sep 8, 2023

Forest: Benchmark Service Infrastructure Plan: success

github-actions bot commented Sep 12, 2023

Forest: Benchmark Service Infrastructure Plan: success

github-actions bot commented Sep 19, 2023

Forest: Benchmark Service Infrastructure Plan: success

jdjaustin commented Aug 23, 2023 •

edited

Loading