Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: favor fractional FIL amounts over a larger number of a smaller unit #5237

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Feb 5, 2025

205.4 FIL over 205400 milliFIL.

Summary of changes

Changes introduced in this pull request:

  • This PR changes the behaviour of the FIL pretty-printer. It's a change in behaviour rather than a bug fix.
  • Previously, the pretty-printer tried to find the biggest prefix that yielded a non-fractional number. Eg. 1001 milliFIL over 1.001 FIL. This PR changes the behaviour to find the biggest prefix that yields a number greater than 1.

Reference issue to close (if applicable)

Closes #4951

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review February 5, 2025 12:10
@lemmih lemmih requested a review from a team as a code owner February 5, 2025 12:10
@lemmih lemmih requested review from LesnyRumcajs and sudo-shashank and removed request for a team February 5, 2025 12:10
@LesnyRumcajs
Copy link
Member

@lemmih no green checkmark!

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 0436f04 Feb 5, 2025
42 checks passed
@LesnyRumcajs LesnyRumcajs deleted the lemmih/use-fractional-fil-amounts branch February 5, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected FIL representation in forest-wallet list
4 participants