address PR comments

ChainSafe · Jun 17, 2022 · 377feca · 377feca
1 parent 6d45df8
commit 377feca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/trie/trie.go b/lib/trie/trie.go
@@ -969,7 +969,8 @@ func (t *Trie) deleteBranch(branch *Node, key []byte) (
 	}
 
 	commonPrefixLength := lenCommonPrefix(branch.Key, key)
-	if (commonPrefixLength + 1) > len(key) {
+	keyDoesNotExist := commonPrefixLength == len(key)
+	if keyDoesNotExist {
 		return branch, false, 0
 	}
 	childIndex := key[commonPrefixLength]

diff --git a/lib/trie/trie_test.go b/lib/trie/trie_test.go
@@ -3606,8 +3606,6 @@ func Test_Trie_delete(t *testing.T) {
 					},
 				}),
 			},
-			updated:      false,
-			nodesRemoved: 0,
 		},
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -3606,8 +3606,6 @@ func Test_Trie_delete(t *testing.T) { @@
     					},
     				}),
     			},
-    			updated:      false,
-    			nodesRemoved: 0,
     		},
     	}
@@ Expand Down @@