Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: implement v0.6.x ext_ functions #905

Closed
11 of 22 tasks
noot opened this issue May 28, 2020 · 1 comment
Closed
11 of 22 tasks

runtime: implement v0.6.x ext_ functions #905

noot opened this issue May 28, 2020 · 1 comment
Assignees

Comments

@noot
Copy link
Contributor

noot commented May 28, 2020

Expected Behavior

imports_old.go (previous ext functions)

  • ext_is_validator
  • ext_local_storage_get
  • ext_local_storage_compare_and_set
  • ext_network_state
  • ext_submit_transaction
  • ext_local_storage_set

imports.go (new ext functions that are ready to be implemented)

  • ext_kill_child_storage
  • ext_child_storage_root
  • ext_clear_child_storage
  • ext_get_allocated_child_storage
  • ext_secp256k1_ecdsa_recover_compressed
  • ext_log

New ext functions that are not specced yet (please create a new issue with the following fns in it when the above functions are implemented)

  • ext_sandbox_memory_new
  • ext_sandbox_memory_teardown
  • ext_sandbox_instantiate
  • ext_sandbox_invoke
  • ext_sandbox_instance_teardown
  • ext_sandbox_memory_get
  • ext_sandbox_memory_set

It will also be a good idea to look at the v0.7 ext_ functions (see spec Appendix E) to see what changes we will need to make to upgrade, and make the v0.6 functions easily wrappable for v0.7.

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT
  • I have provided as much information as possible and necessary
  • I am planning to submit a pull request to fix this issue myself
@edwardmack
Copy link
Contributor

Items remaining undone on checklist because these have not been spec'd yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants