lib/runtime: implement ext_local_storage_set and ext_local_storage_get #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
reviewed
Sep 18, 2020
noot
reviewed
Sep 18, 2020
noot
reviewed
Sep 18, 2020
noot
reviewed
Sep 18, 2020
lib/runtime/storage.go
Outdated
| // You should have received a copy of the GNU Lesser General Public License | ||
| // along with the gossamer library. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| package runtime |
There was a problem hiding this comment.
it might make more sense to have this in the dot/state package, since that's where all the database related functionality is
There was a problem hiding this comment.
when I move this to dot/state I get an import cycle, any suggestions?
package github.com/ChainSafe/gossamer/lib/runtime
imports github.com/ChainSafe/gossamer/dot/state
imports github.com/ChainSafe/gossamer/lib/genesis
imports github.com/ChainSafe/gossamer/lib/runtime: import cycle not allowed
noot
reviewed
Sep 18, 2020
lib/runtime/storage.go
Outdated
Comment on lines
40
to
57
| // NewNodeStorageDB instantiates badgerDB instance for storing runtime persistent data | ||
| func NewNodeStorageDB(db chaindb.Database) *NodeStorageDB { | ||
| return &NodeStorageDB{ | ||
| db, | ||
| } | ||
| } | ||
|
|
||
| // Put appends `storage` to the key and sets the key-value pair in the db | ||
| func (storageDB *NodeStorageDB) Put(key, value []byte) error { | ||
| key = append(storagePrefix, key...) | ||
| return storageDB.db.Put(key, value) | ||
| } | ||
|
|
||
| // Get appends `storage` to the key and retrieves the value from the db | ||
| func (storageDB *NodeStorageDB) Get(key []byte) ([]byte, error) { | ||
| key = append(storagePrefix, key...) | ||
| return storageDB.db.Get(key) | ||
| } |
There was a problem hiding this comment.
it would be nice to use table to add the prefixes instead of doing it manually, see #1091
There was a problem hiding this comment.
Yes, this is much better.
noot
reviewed
Sep 18, 2020
|
This is ready for a re-review. |
noot
reviewed
Sep 22, 2020
lib/runtime/runtime.go
Outdated
| @@ -29,21 +29,35 @@ import ( | |||
| var memory, memErr = wasm.NewMemory(17, 0) | |||
| var logger = log.New("pkg", "runtime") | |||
|
|
|||
| // NodeStorageTypePersistent flog to identify offchain storage as persistent (db) | |||
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
BasicStorageinterface andNodeStoragestruct to use for runtime offchain worker storage.ext_local_storage_setandext_local_storage_getfunctionsTests
Checklist
Issues