Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/runtime: implement ext_kill_child_storage and ext_get_allocated_child_storage #1110

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

edwardmack
Copy link
Contributor

@edwardmack edwardmack commented Sep 28, 2020

Changes

  • Implement ext_kill_child_storage as defined in spec F.1.14
  • Implement ext_get_allocated_child_storage as defined in spec F.1,12
  • Update child storage prefix to :child_storage:default: as defined in spec F.1.9

Tests

go test ./lib/runtime/...

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@edwardmack edwardmack requested a review from noot September 28, 2020 22:21
@edwardmack edwardmack self-assigned this Sep 28, 2020
@@ -23,7 +23,7 @@ import (
)

// ChildStorageKeyPrefix is the prefix for all child storage keys
var ChildStorageKeyPrefix = []byte(":child_storage:")
var ChildStorageKeyPrefix = []byte(":child_storage:default:")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this change from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spec, F.1.9 it says this key must be prefixed with :child_storage:default:

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@edwardmack edwardmack merged commit 25393f3 into development Sep 30, 2020
@edwardmack edwardmack deleted the ed/ext_child_storage branch September 30, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants