fix(dot/sync): fix block request and response logic #1907

noot · 2021-10-18T16:22:53Z

Changes

fix workerToRequests for the descending block request case, need to send out request with lowest blocks first
fix CreateBlockResponse logic, previously was not handling start or end hashes at all :/

Tests

go test ./dot/sync

Issues

related to create gossamer devnet and document issues #1479

Primary Reviewer

@EclesioMeloJunior

…/sync-fix-response

codecov · 2021-10-19T12:26:42Z

Codecov Report

Merging #1907 (d735eef) into development (8c8f6d0) will increase coverage by 0.07%.
The diff coverage is 73.39%.

@@               Coverage Diff               @@
##           development    #1907      +/-   ##
===============================================
+ Coverage        60.00%   60.08%   +0.07%     
===============================================
  Files              180      180              
  Lines            17909    18062     +153     
===============================================
+ Hits             10747    10852     +105     
- Misses            5374     5404      +30     
- Partials          1788     1806      +18

Flag	Coverage Δ
unit-tests	`60.08% <73.39%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/network/notifications.go	`74.05% <0.00%> (ø)`
dot/state/block.go	`45.61% <0.00%> (-0.65%)`	⬇️
dot/sync/message.go	`70.00% <74.45%> (+4.78%)`	⬆️
dot/sync/chain_sync.go	`55.18% <81.81%> (+0.40%)`	⬆️
dot/sync/syncer.go	`32.50% <100.00%> (+1.73%)`	⬆️
dot/sync/tip_syncer.go	`83.33% <100.00%> (+0.31%)`	⬆️
dot/state/block_notify.go	`78.37% <0.00%> (-10.82%)`	⬇️
dot/core/service.go	`52.91% <0.00%> (-0.78%)`	⬇️
dot/network/connmgr.go	`79.64% <0.00%> (+0.88%)`	⬆️
lib/grandpa/vote_message.go	`84.56% <0.00%> (+1.23%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8f6d0...d735eef. Read the comment docs.

arijitAD · 2021-10-20T13:10:48Z

dot/sync/chain_sync.go

+
+	// if our direction is descending, we want to send out the request with the lowest
+	// startNumber first
+	if w.direction == network.Descending {


Can we directly do this inside loop instead of outside?

idx := i if w.direction == network.Descending { idx = numRequests - idx - 1 } reqs[idx] = &network.BlockRequestMessage{ RequestedData: w.requestData, StartingBlock: *start, EndBlockHash: end, Direction: w.direction, Max: &max, }

what do you mean exactly?

dot/sync/message.go

dot/sync/interface.go

dot/sync/message.go

qdm12 · 2021-10-21T23:54:36Z

dot/sync/message.go

+			// that is an ancestor of the end block
+			sh, err := s.blockState.GetHashByNumber(big.NewInt(int64(startNumber)))
+			if err != nil {
+				return nil, fmt.Errorf("failed to get start block %d for request: %w", startNumber, err)


nit general comment/question: there is no rule/convention if we should wrap the error we receive with context or the other way around (have a package defined error wrapping the error we get), but I tend to prefer the package local error wrapping the error received, such that a caller doesn't have to dig through calls to find what to errors.Is against. Otherwise I don't really the point of wrapping errors. Any suggestion on that one (I'm happy to hear counter arguments too!)?

sorry do you mean having a local package error being wrapped, and then the other error being a string? I generally like wrapping the lower-most error since that's the error I usually end up checking for, but definitely open to discussion on this!

Yes, exactly. I wonder if there is a way to wrap an error but be able to errors.Is(err, x) with x being at different call levels. So far, it's either the lowest level or the highest level if I'm not mistaken. Anyway, more of a general comment/discussion, nothing pressing.

Ah I've been searching this thread yesterday 😄 It turns out you can't wrap more than 1 error, but I'll develop a small Go library to be able to have a chain (slice) of errors in an error, ideally integrating with the current standard error interface. I'll let you know! Anyway, for now I think we should wrap the bottom error and not the other way around.

dot/sync/message.go

dot/sync/message_test.go

dot/sync/message.go

dot/sync/message_test.go

…/sync-fix-response

dot/sync/message.go

dot/sync/chain_sync.go

dot/sync/message.go

dot/sync/syncer.go

…/sync-fix-response

dot/sync/message.go

…/sync-fix-response

qdm12

Looks good 👍 Just a few additional comments

qdm12 · 2021-10-28T17:23:15Z

dot/sync/chain_sync.go

+			// if we're doing descending requests and not at the last (highest starting) request,
+			// then use number as start block
+			if w.direction == network.Descending && i != numRequests-1 {
+				start, _ = variadic.NewUint64OrHash(startNumber)


Maybe use the Must equivalent? Just in case we modify NewUint64OrHash eventually, to avoid bad surprises.

qdm12 · 2021-10-28T17:23:45Z

dot/sync/chain_sync.go

+		switch w.direction {
+		case network.Ascending:
+			startNumber += maxResponseSize
+		case network.Descending:
+			startNumber -= maxResponseSize
+		}


Why not if/else? Are we expecting more directions?

no, but I think in general we kinda like switch statements here :p what do you think?

I think

if / else if two cases only

switch for more than two cases. Don't use else if 😉

But I'm happy with switch as well. Although the only thing scaring me is if one additional case is added in the future and this block isn't updated, nothing will be executed whereas an if / else, the else gets executed. But that's a bit silly too I have to admit!

qdm12 · 2021-10-28T17:27:49Z

dot/sync/message.go

+			// that is an ancestor of the end block
+			sh, err := s.blockState.GetHashByNumber(big.NewInt(int64(startNumber)))
+			if err != nil {
+				return nil, fmt.Errorf("failed to get start block %d for request: %w", startNumber, err)


Ah I've been searching this thread yesterday 😄 It turns out you can't wrap more than 1 error, but I'll develop a small Go library to be able to have a chain (slice) of errors in an error, ideally integrating with the current standard error interface. I'll let you know! Anyway, for now I think we should wrap the bottom error and not the other way around.

dot/sync/message.go

qdm12 · 2021-10-28T17:31:51Z

dot/sync/message.go

+// if used with an Descending request, ancestor is the end block and descendant is the start block
+func (s *Service) checkOrGetDescendantHash(ancestor common.Hash, descendant *common.Hash, descendantNumber *big.Int) (common.Hash, error) {
+	if descendantNumber == nil {
+		return common.Hash{}, errors.New("descendantNumber is nil")


nit make this a global error please 🙏

qdm12 · 2021-10-28T17:34:34Z

dot/sync/message.go

-		return nil, errors.New("invalid BlockRequest direction")
+
+		if descendant == nil {
+			return common.Hash{}, fmt.Errorf("failed to find descendant block with number %d", descendantNumber)


nit make this a global error and use something like

Suggested change

return common.Hash{}, fmt.Errorf("failed to find descendant block with number %d", descendantNumber)

return common.Hash{}, fmt.Errorf("%w: with number %d", ErrFindDescendantBlock descendantNumber)

qdm12 · 2021-10-28T17:35:05Z

dot/sync/errors.go

+	errInvalidRequestDirection    = errors.New("invalid request direction")
+	errRequestStartTooHigh        = errors.New("request start number is higher than our best block")
+	errFailedToGetEndHashAncestor = errors.New("failed to get ancestor of end block")


If we do wrap only the bottom errors, we need to export all of them so a caller can check errors against them.

only this package deals with block requests/responses, so I don't think they need to be exported atm

Yes, but ultimately aren't these errors returned outside of the sync package somewhere? Maybe they're logged in this package, then yes let's keep them unexported.

I don't think they are, they're only returned to other places in this package I believe (and just logged)

qdm12 · 2021-10-28T17:38:03Z

dot/sync/message.go

+	for idx, bn := 0, start; bn <= end; idx, bn = idx+1, bn+1 {
+		data[idx], err = s.getBlockDataByNumber(big.NewInt(int64(bn)), requestedData)
+		if err != nil {
+			return nil, err
+		}
+	}


nit that for loop makes my brain go woowoo, maybe simplifying a bit like:

(same for below loop in handleDescendingByNumber)

Suggested change

for idx, bn := 0, start; bn <= end; idx, bn = idx+1, bn+1 {

data[idx], err = s.getBlockDataByNumber(big.NewInt(int64(bn)), requestedData)

if err != nil {

return nil, err

}

}

for i := 0; start+i <= end; i++ {

blockNumber := int64(start+i)

data[i], err = s.getBlockDataByNumber(big.NewInt(blockNumber), requestedData)

if err != nil {

return nil, err

}

}

qdm12 · 2021-10-28T17:41:54Z

dot/sync/message_test.go


+	// test ascending


Can we run two subtests with a name instead of this comment perhaps?

qdm12 · 2021-10-28T17:42:07Z

dot/sync/message_test.go

+	req = &network.BlockRequestMessage{
+		RequestedData: 3,
+		StartingBlock: *start,
+		EndBlockHash:  nil,


nit I'm not sure initializing things to their Go defaults is really useful right? (applies to below struct init too)

Suggested change

EndBlockHash: nil,

yeah I mostly just put it for explicit-ness reasons, but can remove

Yes I get your point, although doing this everywhere adds quite a bit of code. The repo being the size it is already, and us not billing by code line, I think it would be good to not do that 🤣 But up for discussion.

qdm12 · 2021-10-28T18:44:21Z

dot/sync/message.go

@@ -307,7 +306,7 @@ func (s *Service) checkOrGetDescendantHash(ancestor common.Hash, descendant *com
 		}

 		if descendant == nil {
-			return common.Hash{}, fmt.Errorf("failed to find descendant block with number %d", descendantNumber)
+			return common.Hash{}, fmt.Errorf("%d with number %d", errFailedToGetDescendant, descendantNumber)


nitnit

Suggested change

return common.Hash{}, fmt.Errorf("%d with number %d", errFailedToGetDescendant, descendantNumber)

return common.Hash{}, fmt.Errorf("%w with number %d", errFailedToGetDescendant, descendantNumber)

…r into noot/sync-fix-response

# [0.6.0](v0.5.0...v0.6.0) (2021-12-03) ### Bug Fixes * **babe:** Fix extrinsic format in block. ([#1530](#1530)) ([1a03b2a](1a03b2a)) * **ci:** add missing go-version matrix to fix development branch CI ([#2037](#2037)) ([6babe76](6babe76)) * **cmd/cfg:** Use Babe Lead value from toml config ([#2032](#2032)) ([06aa3e3](06aa3e3)) * cmd/gossamer: Generate random name if --name flag not set ([#1506](#1506)) ([3c05a88](3c05a88)) * confirm block import notifier is closed properly ([#1736](#1736)) ([ad2d85e](ad2d85e)) * **docs:** improve build-spec usage docs ([#1706](#1706)) ([2e164b4](2e164b4)) * **dot/core:** Add only extrinsic during chain reorg. ([#1609](#1609)) ([29413d4](29413d4)) * **dot/core:** Batch process transaction message. ([#1780](#1780)) ([0064836](0064836)) * **dot/core:** check transaction Validity.Propagate field to determine whether to propagate tx ([#1643](#1643)) ([81f23cc](81f23cc)) * **dot/core:** Fix handle transaction message test. ([#1607](#1607)) ([58b8725](58b8725)) * **dot/network, lib/grandpa:** fix handshake decoding and grandpa message handler sigabort ([#1631](#1631)) ([887f72c](887f72c)) * **dot/network, lib/grandpa:** fix node sync, improve devnet finality ([bcc7935](bcc7935)) * **dot/network:** add nil checks in connManager ([#2069](#2069)) ([7f9c042](7f9c042)) * **dot/network:** Check for size when decoding leb128. ([#1634](#1634)) ([d082b9e](d082b9e)) * **dot/network:** check if peer supports protocol ([#1617](#1617)) ([6bf66a4](6bf66a4)) * **dot/network:** decrease DHT find peers interval for gssmr nodes ([#1703](#1703)) ([08516a0](08516a0)) * **dot/network:** fix bugs in notifications protocol handlers; add metrics for inbound/outbound streams ([#2010](#2010)) ([8c2993d](8c2993d)) * **dot/network:** fix dht connection on discovery on devnet ([#2059](#2059)) ([da065b8](da065b8)) * **dot/network:** fix discovery between gossamer nodes ([#1594](#1594)) ([f4c79d3](f4c79d3)) * **dot/network:** fix justification request at head logic ([#1510](#1510)) ([98d1413](98d1413)) * **dot/network:** fix memory allocations with `sizedBufferPool` ([#1963](#1963)) ([e0b126b](e0b126b)) * **dot/network:** Fix missing digest in header ([#2092](#2092)) ([21ea85e](21ea85e)) * **dot/network:** Fix notification handshake and reuse stream. ([#1545](#1545)) ([a632dc4](a632dc4)) * **dot/network:** fix receiving notifications messages from substrate peers ([#1517](#1517)) ([fdf3c53](fdf3c53)) * **dot/network:** fix stream manager tests ([#1683](#1683)) ([e02eca4](e02eca4)) * **dot/network:** implement a handshake timeout ([#1615](#1615)) ([87c2f63](87c2f63)) * **dot/network:** Implement time based handle transaction ([#1942](#1942)) ([dd08424](dd08424)) * **dot/network:** move low reputation peer removal from network ConnManager to peer scoring logic (dot/peerstate) ([#2068](#2068)) ([ac16285](ac16285)), closes [#2039](#2039) * **dot/network:** Return on EOF error while reading stream. ([#1733](#1733)) ([f447eac](f447eac)) * **dot/network:** split stored streams and handshakeData into inbound and outbound ([#1553](#1553)) ([637050b](637050b)) * **dot/network:** update notificationsProtocol handshakeData to sync.Map ([#1492](#1492)) ([22f7269](22f7269)) * **dot/node:** Start websocket server only with `--ws` flag ([#1671](#1671)) ([6ecef3b](6ecef3b)) * **dot/state, lib/babe, lib/trie:** improve syncing between gossamer authority nodes ([#1613](#1613)) ([ca99fbf](ca99fbf)) * **dot/state, lib/grandpa:** update justification and SignedVote handling in database ([#1682](#1682)) ([bbdcd6f](bbdcd6f)) * **dot/state,dot/network:** improve memory usage when syncing ([#1491](#1491)) ([3b2ad8d](3b2ad8d)) * **dot/state:** add StorageState Lock/Unlock API for usage by babe and sync ([#1700](#1700)) ([3c22ace](3c22ace)) * **dot/state:** fix deadlock, fixes bootstrap syncing ([#1959](#1959)) ([dd80c09](dd80c09)) * **dot/state:** fix usage of trie.Snapshot ([#1489](#1489)) ([3880a40](3880a40)) * **dot/state:** track runtime per-block, fix runtime upgrades differing between forks ([#1638](#1638)) ([e133884](e133884)) * **dot/state:** update `*state.BlockState.AddBlockToBlockTree` to store block in `unfinalisedBlocksMap` ([#2006](#2006)) ([55d997f](55d997f)) * **dot/sync:** add nil header checks ([#2099](#2099)) ([a7d4be0](a7d4be0)) * **dot/sync:** fix block request and response logic ([#1907](#1907)) ([9c6283e](9c6283e)) * **dot/sync:** fix creating block response, fixes node sync between gossamer nodes ([#1572](#1572)) ([1328c80](1328c80)) * **dot/telemetry:** refactor telemetry to reduce CPU usage ([#1597](#1597)) ([bc31ac7](bc31ac7)) * **dot/types:** *types.Body to be of type []types.Extrinsic ([#1807](#1807)) ([4c09715](4c09715)) * **dot/types:** fix max value for digest ([#1687](#1687)) ([48405e7](48405e7)) * **dot:** fix `TestNewNode` ([#2070](#2070)) ([42908d0](42908d0)) * fix edit link ([#1507](#1507)) ([5089327](5089327)) * fix Kusama sync; add storageState lock in core.HandleTransactionMessage ([#1783](#1783)) ([1d688e4](1d688e4)) * **lib/babe, lib/runtime/wasmer:** fixes for v0.9.8+ runtime ([#2075](#2075)) ([2f9f80c](2f9f80c)) * **lib/babe:** add `--babe-lead` flag, update epoch handling logic ([#1895](#1895)) ([7abcce6](7abcce6)) * **lib/babe:** add pre-runtime digest before calling initialize_block ([#1581](#1581)) ([c1b26d3](c1b26d3)) * **lib/babe:** always use 2/3 of slot to produce block, re-add potentially valid txs to queue ([#1679](#1679)) ([cf93ad3](cf93ad3)) * **lib/babe:** call AddBlock in BABE synchronously ([#1585](#1585)) ([86acc43](86acc43)) * **lib/babe:** fix BABE state storing after building block ([#1536](#1536)) ([1a3dea2](1a3dea2)) * **lib/babe:** fix err log ([#1801](#1801)) ([a96f06a](a96f06a)) * **lib/babe:** fix setting first slot of network, fix loading BABE epoch params ([#1640](#1640)) ([5c3dbfe](5c3dbfe)) * **lib/babe:** fix timing for transition between epochs ([#1636](#1636)) ([57027db](57027db)) * **lib/blocktree:** fix blocktree bug ([#2060](#2060)) ([c17b53a](c17b53a)) * **lib/blocktree:** fix potential nil pointer dereference in `HighestCommonAncestor`, core `handleBlocksAsync` ([#1993](#1993)) ([f7f4463](f7f4463)) * **lib/blocktree:** fix setting leaves after blocktree pruning ([#1605](#1605)) ([58c0854](58c0854)) * **lib/blocktree:** removes the inconsistency to choose a deepest leaf ([#2094](#2094)) ([43d68e3](43d68e3)) * **lib/crypto/ed25519:** update ed25519 to use go-schnorrkel bip39 derivation ([#1488](#1488)) ([dfb95d2](dfb95d2)) * **lib/genesis:** Update missing and incorrect fields in genesis file. ([#1681](#1681)) ([8207704](8207704)) * **lib/grandpa:** fix grandpa stall and various bugs ([#1708](#1708)) ([67c93f4](67c93f4)) * **lib/grandpa:** fix grandpa vote message switch ([#2095](#2095)) ([461890c](461890c)) * **lib/grandpa:** fix threshold checking to be strictly greater than 2/3 ([#1891](#1891)) ([66ffe51](66ffe51)) * **lib/grandpa:** use `defaultGrandpaInterval` if not set, fixes error on startup ([#1982](#1982)) ([75627b5](75627b5)) * **lib/runtime/life:** remove import C from life ([#1923](#1923)) ([ed507d2](ed507d2)) * **lib/runtime:** update HOST_API_TEST_RUNTIME_URL to reference specific commit ([#1885](#1885)) ([666ed06](666ed06)) * **log-levels:** do not ignore configuration file log levels ([#2016](#2016)) ([80879b2](80879b2)) * pending bubble hidden after block included ([#1592](#1592)) ([5826322](5826322)) * persist node name ([#1543](#1543)) ([88b88f2](88b88f2)) * **pprof:** only run pprof service if enabled ([#2073](#2073)) ([55669c5](55669c5)) * **release:** Trigger release when pushed to main branch. ([#1566](#1566)) ([d445c97](d445c97)) * **rpc/subscription:** subscribe runtime version notify when version changes ([#1686](#1686)) ([9a76d39](9a76d39)) * Staging CI workflow ([#2034](#2034)) ([84ec792](84ec792)) * **trie:** memory leak fix in `lib/trie` ([#2009](#2009)) ([0ad5eb7](0ad5eb7)) * update deprecated package ([#1603](#1603)) ([f195204](f195204)) * update go-schnorrkel version ([#1557](#1557)) ([b86c7ff](b86c7ff)) * update gssmr genesis to use pallet_babe::SameAuthoritiesForever ([#1696](#1696)) ([fb0a751](fb0a751)) * update HOST_API_TEST_RUNTIME_URL ([#1898](#1898)) ([2ef59a8](2ef59a8)) * **utils:** create a specific folder for database ([#1598](#1598)) ([8c67795](8c67795)) ### Features * add --chain dev option ([#1561](#1561)) ([04a2969](04a2969)) * Add properties and chainId on build-spec command ([#1520](#1520)) ([b18290c](b18290c)) * cmd: implement import-runtime subcommand ([#1483](#1483)) ([d82b2da](d82b2da)) * **cmd/gossamer:** implement --telemetry-url parameter ([#1890](#1890)) ([b202e89](b202e89)), closes [#1502](#1502) * **cmd:** implement offline pruning of state trie ([#1564](#1564)) ([af9c925](af9c925)) * **devnet:** Local Gossamer Devnet ([#2008](#2008)) ([a520001](a520001)) * **dot/network, lib/grandpa:** request justification on receiving NeighbourMessage, verify justification on receipt ([#1529](#1529)) ([e1f9f42](e1f9f42)) * **dot/network:** Add cache for network message. ([#1511](#1511)) ([accaf69](accaf69)) * **dot/network:** add propagate return bool to messageHandler func type to determine whether to propagate message or not ([#1555](#1555)) ([0d6f488](0d6f488)) * **dot/network:** implement persistent peers functionality ([#1512](#1512)) ([7850532](7850532)) * **dot/network:** implement streamManager to cleanup not recently used streams ([#1611](#1611)) ([ba861bf](ba861bf)) * **dot/network:** request block justifications when near head ([#1499](#1499)) ([ae7012b](ae7012b)) * **dot/peerset:** Implement peer scoring ([#1791](#1791)) ([1c989ad](1c989ad)) * **dot/rpc/modules:** add `system_addReservedPeer` and `system_removeReservedPeer` RPC call ([#1712](#1712)) ([dba5922](dba5922)) * **dot/rpc:** Add `system_localListenAddresses` RPC call ([#1689](#1689)) ([c981d2e](c981d2e)) * **dot/rpc:** Implement `childstate_getKeys` rpc call ([#1800](#1800)) ([9b2f41e](9b2f41e)) * **dot/rpc:** implement sync_state_genSyncSpec RPC call ([#1827](#1827)) ([2186caf](2186caf)) * **dot/state:** implement online pruning of historical state tries ([#1596](#1596)) ([3eb9399](3eb9399)) * **dot/sync:** implement codeSubstitutes ([#1635](#1635)) ([d87aaeb](d87aaeb)) * dot/telemetry: Implement basic telemetry connection ([#1497](#1497)) ([fcb4159](fcb4159)) * **dot/telemetry:** Added connection retry ([#1904](#1904)) ([579a791](579a791)) * **dot/telemetry:** Added more telemetry messages in grandpa client ([#2043](#2043)) ([2e57d15](2e57d15)), closes [#1841](#1841) [#1842](#1842) * **dot/telemetry:** implement notify.finalized telemetry interface ([#1877](#1877)) ([de1a60d](de1a60d)) * **dot/telemetry:** implement substrate_number_leaves metrics ([#1926](#1926)) ([69823c0](69823c0)) * **dot/telemetry:** implement telemetry message network_state ([#1618](#1618)) ([a81844e](a81844e)) * **flags:** read log levels from flags ([#1953](#1953)) ([9694e46](9694e46)) * implement ext_default_child_storage_storage_kill_version_2 ([#1799](#1799)) ([c2908ae](c2908ae)) * implement ext_offchain_index_set_version_1 for wasmer runtime ([#1739](#1739)) ([96c30a6](96c30a6)) * **lib/babe:** add check of types.ConfigData.SecondarySlots for disabling secondary verification ([#1910](#1910)) ([cd27ae4](cd27ae4)) * **lib/grandpa:** fully verify justifications using GrandpaState ([#1544](#1544)) ([028d25e](028d25e)) * **lib/grandpa:** Include equivocatory nodes while creating justification ([#1911](#1911)) ([aca86b6](aca86b6)) * **lib/grandpa:** send NeighbourMessage to peers ([#1558](#1558)) ([322ccf9](322ccf9)) * **lib/runtime/wasmer:** implement ext_default_child_storage_storage_kill_version_3 ([#1878](#1878)) ([a719a60](a719a60)) * **lib/runtime/wasmer:** implement ext_offchain_local_storage_version_1 ([#1821](#1821)) ([0f63b17](0f63b17)) * **lib/runtime:** Implement `ext_offchain_http_request_add_header_version_1` host function ([#1994](#1994)) ([0a30b3d](0a30b3d)) * **lib/runtime:** Implement `ext_offchain_http_request_start_version_1` host function ([#1947](#1947)) ([974b1fc](974b1fc)) * **lib/runtime:** Implement `trie_blake2_256_verify_proof` host function ([#1920](#1920)) ([506565d](506565d)) * **lib/trie:** Implement `verify_proof` function ([#1883](#1883)) ([67bb5ef](67bb5ef)) * **lib/trie:** Implement limit for trie.ClearPrefix ([#1905](#1905)) ([becec9e](becec9e)) * **lib/trie:** Parallel hash trie. ([#1657](#1657)) ([22827e7](22827e7)) * **pprof:** Pprof HTTP server service ([#1991](#1991)) ([ce24ea9](ce24ea9)) * **rpc/subscription:** implement state_unsubscribeStorage ([#1574](#1574)) ([7574f10](7574f10)) * **rpc:** Implement `childstate_getChildStorage` RPC call ([#1832](#1832)) ([3d949f2](3d949f2)) * **rpc:** Implement `childstate_getStorageHash` RPC call ([#1805](#1805)) ([e539bd3](e539bd3)) * **rpc:** Implement `childstate_getStorageSize` RPC call ([#1810](#1810)) ([a04deb6](a04deb6)) * **rpc:** Implement `payment_queryInfo` RPC call ([#1826](#1826)) ([7a5deec](7a5deec)) * **rpc:** Implement `state_getReadProof` rpc call ([#1768](#1768)) ([865f80f](865f80f)) * **runtime:** implement custom logging handler that print function name ([#1825](#1825)) ([2b1276d](2b1276d)) * **telemetry:** send telemetry messages when GRANDPA receieves commit or vote messages ([#2015](#2015)) ([7bf40e1](7bf40e1)), closes [#1840](#1840) [#1839](#1839) [#1838](#1838) * **telemetry:** send txpool.import telemetry msg ([#1966](#1966)) ([ffc81bf](ffc81bf)) ### Reverts * Revert "feat(dot/rpc) implement `author_hasSessionKeys` RPC call (#1704)" (#1714) ([65380fd](65380fd)), closes [#1704](#1704) [#1714](#1714)

github-actions · 2021-12-03T21:07:35Z

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix block response logic

8951703

noot self-assigned this Oct 18, 2021

noot changed the base branch from noot/sync-babe-fix to development October 18, 2021 16:26

noot added 5 commits October 19, 2021 07:23

update logs

f0250e9

cleanup

7b07d9d

cleanup more

bdc5565

cleanup more

3e64089

Merge branch 'development' of github.com:ChainSafe/gossamer into noot…

ad9815b

…/sync-fix-response

noot marked this pull request as ready for review October 19, 2021 11:54

noot requested review from arijitAD, EclesioMeloJunior, edwardmack, jimjbrettj, kishansagathiya, omar391 and timwu20 as code owners October 19, 2021 11:54

noot added the Status: Review Needed label Oct 19, 2021

arijitAD reviewed Oct 20, 2021

View reviewed changes

qdm12 reviewed Oct 22, 2021

View reviewed changes

noot added 2 commits October 25, 2021 06:47

Merge branch 'development' of github.com:ChainSafe/gossamer into noot…

38f917b

…/sync-fix-response

address comments

21cb17d

address comments

5d921eb

noot requested a review from qdm12 October 25, 2021 13:30

EclesioMeloJunior requested changes Oct 25, 2021

View reviewed changes

dot/sync/message.go Outdated Show resolved Hide resolved

dot/sync/chain_sync.go Show resolved Hide resolved

EclesioMeloJunior requested changes Oct 25, 2021

View reviewed changes

dot/sync/message.go Show resolved Hide resolved

dot/sync/message.go Outdated Show resolved Hide resolved

dot/sync/message.go Outdated Show resolved Hide resolved

dot/sync/syncer.go Outdated Show resolved Hide resolved

noot added 2 commits October 27, 2021 13:07

address comments

2312609

fix handleDescendingByNumber for loop

95431ce

noot requested a review from EclesioMeloJunior October 27, 2021 17:10

noot added 2 commits October 27, 2021 13:10

Merge branch 'development' of github.com:ChainSafe/gossamer into noot…

2a9afb9

…/sync-fix-response

fix merge issues

8985831

EclesioMeloJunior approved these changes Oct 27, 2021

View reviewed changes

dot/sync/message.go Show resolved Hide resolved

Merge branch 'development' of github.com:ChainSafe/gossamer into noot…

866d76a

…/sync-fix-response

qdm12 approved these changes Oct 28, 2021

View reviewed changes

noot added 2 commits October 28, 2021 13:51

update workerToRequests target hash param

8e46510

address comments

997f988

qdm12 reviewed Oct 28, 2021

View reviewed changes

noot and others added 3 commits October 28, 2021 16:52

Merge branch 'development' into noot/sync-fix-response

c2425d8

address comments

08d513c

Merge branch 'noot/sync-fix-response' of github.com:ChainSafe/gossame…

d735eef

…r into noot/sync-fix-response

noot merged commit 9c6283e into development Oct 29, 2021

noot deleted the noot/sync-fix-response branch October 29, 2021 01:00

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021

fix(dot/sync): fix block request and response logic (ChainSafe#1907)

fcfbabe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dot/sync): fix block request and response logic #1907

fix(dot/sync): fix block request and response logic #1907

noot commented Oct 18, 2021

codecov bot commented Oct 19, 2021 •

edited

Loading

arijitAD Oct 20, 2021

noot Oct 25, 2021

qdm12 Oct 21, 2021

noot Oct 25, 2021

qdm12 Oct 25, 2021

qdm12 Oct 28, 2021

qdm12 left a comment

qdm12 Oct 28, 2021

qdm12 Oct 28, 2021

noot Oct 28, 2021

qdm12 Oct 28, 2021 •

edited

Loading

qdm12 Oct 28, 2021

qdm12 Oct 28, 2021

qdm12 Oct 28, 2021

qdm12 Oct 28, 2021

noot Oct 28, 2021

qdm12 Oct 28, 2021

noot Oct 28, 2021

qdm12 Oct 28, 2021

qdm12 Oct 28, 2021

qdm12 Oct 28, 2021

noot Oct 28, 2021

qdm12 Oct 28, 2021

qdm12 Oct 28, 2021

github-actions bot commented Dec 3, 2021

	return common.Hash{}, fmt.Errorf("failed to find descendant block with number %d", descendantNumber)
	return common.Hash{}, fmt.Errorf("%w: with number %d", ErrFindDescendantBlock descendantNumber)

	return common.Hash{}, fmt.Errorf("%d with number %d", errFailedToGetDescendant, descendantNumber)
	return common.Hash{}, fmt.Errorf("%w with number %d", errFailedToGetDescendant, descendantNumber)

fix(dot/sync): fix block request and response logic #1907

fix(dot/sync): fix block request and response logic #1907

Conversation

noot commented Oct 18, 2021

Changes

Tests

Issues

Primary Reviewer

codecov bot commented Oct 19, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qdm12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qdm12 Oct 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 3, 2021

codecov bot commented Oct 19, 2021 •

edited

Loading

qdm12 Oct 28, 2021 •

edited

Loading