Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): do not pin down to the bugfix version #2467

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Apr 5, 2022

Changes

  • go install: do not pin to a bug fix version so we get the latest bug fixes
  • Use make license in copyright workflow
  • Pin google.golang.org/protobuf/cmd/protoc-gen-go to v1.28

Tests

Issues

Primary Reviewer

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #2467 (9bdb5e9) into development (0b4f33d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #2467   +/-   ##
============================================
  Coverage        61.66%   61.67%           
============================================
  Files              216      216           
  Lines            28218    28218           
============================================
+ Hits             17402    17404    +2     
+ Misses            9062     9057    -5     
- Partials          1754     1757    +3     
Flag Coverage Δ
unit-tests 61.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/network/service.go 56.84% <0.00%> (-1.40%) ⬇️
dot/network/host.go 64.31% <0.00%> (-1.07%) ⬇️
lib/grandpa/grandpa.go 59.93% <0.00%> (-0.43%) ⬇️
dot/sync/chain_sync.go 53.42% <0.00%> (-0.31%) ⬇️
dot/network/notifications.go 65.17% <0.00%> (+1.37%) ⬆️
dot/network/inbound.go 100.00% <0.00%> (+7.01%) ⬆️
dot/state/block_notify.go 90.47% <0.00%> (+8.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4f33d...9bdb5e9. Read the comment docs.

@qdm12 qdm12 force-pushed the qdm12/ci/pin-feature-only branch from 260485b to 9bdb5e9 Compare April 5, 2022 17:43
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qdm12 qdm12 merged commit 98400b3 into development Apr 6, 2022
@qdm12 qdm12 deleted the qdm12/ci/pin-feature-only branch April 6, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants