Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib/grandpa): SignedMessage Hash to BlockHash #2491

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Apr 22, 2022

Changes

Just rename SignedMessage Hash field to BlockHash to avoid any confusion

Tests

go test -tags integration github.com/ChainSafe/gossamer/lib/grandpa

Issues

Created following a discussion from #2485

Primary Reviewer

@jimjbrettj

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2491 (df14566) into development (89c32ae) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@               Coverage Diff               @@
##           development    #2491      +/-   ##
===============================================
+ Coverage        61.57%   61.58%   +0.01%     
===============================================
  Files              215      215              
  Lines            28215    28215              
===============================================
+ Hits             17372    17376       +4     
+ Misses            9079     9076       -3     
+ Partials          1764     1763       -1     
Flag Coverage Δ
unit-tests 61.58% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/grandpa/message.go 63.30% <0.00%> (ø)
lib/grandpa/message_tracker.go 65.93% <100.00%> (ø)
lib/grandpa/vote_message.go 83.70% <100.00%> (ø)
dot/network/notifications.go 63.79% <0.00%> (-1.38%) ⬇️
dot/network/light.go 85.25% <0.00%> (-0.80%) ⬇️
dot/state/epoch.go 49.29% <0.00%> (ø)
dot/network/inbound.go 92.98% <0.00%> (ø)
lib/runtime/wasmer/imports.go 48.45% <0.00%> (+0.04%) ⬆️
dot/telemetry/mailer.go 61.19% <0.00%> (+4.47%) ⬆️
dot/network/block_announce.go 63.20% <0.00%> (+4.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c32ae...df14566. Read the comment docs.

Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@qdm12 qdm12 merged commit 30601d3 into development Apr 26, 2022
@qdm12 qdm12 deleted the qdm12/grandpa/signedmessage-hash branch April 26, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants