Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot/rpc Implement RPC call state_getMetadata #853

Merged
merged 5 commits into from
May 15, 2020
Merged

dot/rpc Implement RPC call state_getMetadata #853

merged 5 commits into from
May 15, 2020

Conversation

edwardmack
Copy link
Contributor

@edwardmack edwardmack commented May 14, 2020 •
edited
Loading

Changes

  • Implement RPC call state_getMetadata which returns the runtime metadata
  • The current runtime has not implemented Metadata_metadata yet, so this will handle the error that is returned.

Tests:

go test ./dot/rpc/...
go test ./lib/runtime/...

Checklist:

  • I have read CONTRIBUTING and CODE_OF_CONDUCT
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • I have linked any relevant issues in my pull request comments
  • All integration tests and required coverage checks are passing

Issues:

@edwardmack edwardmack self-assigned this May 14, 2020
noot
noot reviewed May 14, 2020
View reviewed changes
dot/rpc/modules/state.go Outdated Show resolved Hide resolved
ryanchristo
ryanchristo approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@edwardmack edwardmack merged commit 54221f9 into development May 15, 2020
@edwardmack edwardmack deleted the ed/rpc_state_getMetadata branch May 15, 2020 14:34
ryanchristo pushed a commit that referenced this pull request Jun 24, 2020
@edwardmack @ryanchristo
dot/rpc Implement RPC call state_getMetadata (#853)
230381b 
* add runtime test for Metadata_metadata call

* implement RPC state_getMetadata

* add tests

* utilize common.BytesToHex method
This was referenced Oct 19, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot approved these changes

@ryanchristo ryanchristo ryanchristo approved these changes

@thomasmodeneis thomasmodeneis Awaiting requested review from thomasmodeneis

Assignees

@edwardmack edwardmack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardmack @ryanchristo @noot