-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use pubsub interface #122
Conversation
}) | ||
}) | ||
}) | ||
|
||
describe('2 nodes', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was initially planning to remove all this file. These tests are mostly redundant now, but all the mesh related expects
are an extension from the interface tests, as they are specific to gossipsub.
We can create new tests to guarantee that the mesh content is properly tested, or keep these tests for now and open an issue to tackle this test refactor later as it is not a priority
6c31d45
to
1f5cc00
Compare
Codecov Report
@@ Coverage Diff @@
## gsv1.1 #122 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 2 2
Lines 24 24
=======================================
Hits 22 22
Misses 2 2
Continue to review full report at Codecov.
|
7d36a97
to
cd6400a
Compare
cd6400a
to
752976e
Compare
752976e
to
e44efdc
Compare
While this still depends on some branches, we can perhaps get this merged as this will not go to master yet. |
527910f
to
9004471
Compare
9004471
to
590b7e4
Compare
This PR moves away from
libp2p-pubsub
base implementation and uses the new (still in PR)interface-pubsub
.The
interface-pubsub
provides some advantages overlibp2p-pubsub
:js-libp2p
per PubSub abstraction API libp2p/js-libp2p-pubsub#68)The current base pubsub implementation in the interface is mostly the content of https://github.com/libp2p/js-libp2p-pubsub/tree/v0.6.x with some changes in the constructor.
This PR aims to:
interface-pubsub
with its base implementation and test suiteNote: The interface still needs to be updated with the content of
pubsub.js
in this repo.Needs: