Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth1 events db tracking #180

Merged
merged 10 commits into from
May 2, 2019
Merged

Eth1 events db tracking #180

merged 10 commits into from
May 2, 2019

Conversation

mpetrunic
Copy link
Member

I will open another PR with fetching of past events from logs.

@mpetrunic mpetrunic requested a review from a team May 1, 2019 11:44
@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #180 into master will decrease coverage by 20.94%.
The diff coverage is 30.43%.

@@             Coverage Diff             @@
##           master     #180       +/-   ##
===========================================
- Coverage   52.79%   31.85%   -20.95%     
===========================================
  Files          85       46       -39     
  Lines        1305      744      -561     
  Branches      123       64       -59     
===========================================
- Hits          689      237      -452     
+ Misses        590      507       -83     
+ Partials       26        0       -26

Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

As an aside, I think we will need to also store post-genesis deposits in some fashion, so that our validators can add the deposits properly on block proposal. https://github.com/ethereum/eth2.0-specs/blob/dev/specs/validator/0_beacon-chain-validator.md#deposits

src/eth1/impl/ethers.ts Show resolved Hide resolved
src/eth1/impl/ethers.ts Show resolved Hide resolved
src/eth1/impl/ethers.ts Show resolved Hide resolved
src/node/index.ts Outdated Show resolved Hide resolved
test/e2e/eth1/deploy.test.ts Outdated Show resolved Hide resolved
@mpetrunic
Copy link
Member Author

As an aside, I think we will need to also store post-genesis deposits in some fashion, so that our validators can add the deposits properly on block proposal. https://github.com/ethereum/eth2.0-specs/blob/dev/specs/validator/0_beacon-chain-validator.md#deposits

I put some comments in code about that, after Eth2Genesis event, per Eth2.0 specs, deposits should be stored in BlockBody during process block operation

GregTheGreek
GregTheGreek previously approved these changes May 2, 2019
@GregTheGreek GregTheGreek dismissed their stale review May 2, 2019 03:31

accident

@mpetrunic
Copy link
Member Author

@ChainSafe/sharding-core can we merge this? I have another one related to this ready :)

@wemeetagain wemeetagain merged commit 6c95988 into ChainSafe:master May 2, 2019
@mpetrunic mpetrunic deleted the mpetrunic/eth1-events-db branch May 2, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants