-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eth1 events db tracking #180
Eth1 events db tracking #180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
===========================================
- Coverage 52.79% 31.85% -20.95%
===========================================
Files 85 46 -39
Lines 1305 744 -561
Branches 123 64 -59
===========================================
- Hits 689 237 -452
+ Misses 590 507 -83
+ Partials 26 0 -26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
As an aside, I think we will need to also store post-genesis deposits in some fashion, so that our validators can add the deposits properly on block proposal. https://github.com/ethereum/eth2.0-specs/blob/dev/specs/validator/0_beacon-chain-validator.md#deposits
I put some comments in code about that, after Eth2Genesis event, per Eth2.0 specs, deposits should be stored in BlockBody during process block operation |
@ChainSafe/sharding-core can we merge this? I have another one related to this ready :) |
I will open another PR with fetching of past events from logs.