Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update libp2p modules #2442

Closed

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Apr 29, 2021

Motivation

Update libp2p to its newest release with better types support, removed Buffer, smaller bundle and other improvements

Description

N/A

Steps to test or reproduce

N/A

Needs:

@codeclimate
Copy link

codeclimate bot commented Apr 29, 2021

Code Climate has analyzed commit 87f8925 and detected 0 issues on this pull request.

View more on Code Climate.

@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2021

This pull request introduces 1 alert when merging d28ea7b into 25f3d53 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@vasco-santos vasco-santos force-pushed the chore/update-libp2p-modules branch from 4c72e51 to 4eb7192 Compare April 30, 2021 15:04

export default pipe;
}
// // Overwrite types until this issue is fixed https://github.com/alanshaw/it-pipe/issues/4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was not fixed yet, but this was the only way I could get the types to work. I think that all Buffer types need to be updated to Uint8Array , in order to have this back in. Can I get help on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


logger.debug("Resp received request", {...logCtx, requestBody} as Context);
logger.debug("Resp received request", {...logCtx, requestBody} as unknown as Context);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consequence of types commented for it-pipe I guess?

@dapplion
Copy link
Contributor

dapplion commented May 1, 2021

@vasco-santos Would you mind running prettier on the modified files for linting to pass?

@vasco-santos
Copy link
Contributor Author

@vasco-santos Would you mind running prettier on the modified files for linting to pass?

just did it, also added a script for lint fix. Anyway, there are a few problems with the linter. Some of them are related to my changes and the it-pipe I believe: Unsafe return of an any typed value

@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale label Jul 8, 2021
@stale stale bot removed the bot:stale label Jul 8, 2021
@dapplion
Copy link
Contributor

dapplion commented Sep 3, 2021

Thanks for the PR @vasco-santos I think Cayman recycled parts of it in his bump deps PR, closing since we are fully up to date now 👍

@dapplion dapplion closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants