-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update libp2p modules #2442
chore: update libp2p modules #2442
Conversation
Code Climate has analyzed commit 87f8925 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request introduces 1 alert when merging d28ea7b into 25f3d53 - view on LGTM.com new alerts:
|
d28ea7b
to
79a7953
Compare
79a7953
to
d1b89a1
Compare
4c72e51
to
4eb7192
Compare
|
||
export default pipe; | ||
} | ||
// // Overwrite types until this issue is fixed https://github.com/alanshaw/it-pipe/issues/4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was not fixed yet, but this was the only way I could get the types to work. I think that all Buffer types need to be updated to Uint8Array , in order to have this back in. Can I get help on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
logger.debug("Resp received request", {...logCtx, requestBody} as Context); | ||
logger.debug("Resp received request", {...logCtx, requestBody} as unknown as Context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consequence of types commented for it-pipe
I guess?
@vasco-santos Would you mind running prettier on the modified files for linting to pass? |
just did it, also added a script for lint fix. Anyway, there are a few problems with the linter. Some of them are related to my changes and the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Thanks for the PR @vasco-santos I think Cayman recycled parts of it in his bump deps PR, closing since we are fully up to date now 👍 |
Motivation
Update libp2p to its newest release with better types support, removed Buffer, smaller bundle and other improvements
Description
N/A
Steps to test or reproduce
N/A
Needs: