-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimistic sync p1 - attest only validated head #3434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit dd66931 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3434 +/- ##
==========================================
- Coverage 37.90% 37.86% -0.04%
==========================================
Files 308 308
Lines 8129 8144 +15
Branches 1248 1252 +4
==========================================
+ Hits 3081 3084 +3
- Misses 4900 4912 +12
Partials 148 148 |
dapplion
reviewed
Nov 16, 2021
g11tech
force-pushed
the
koptsync
branch
2 times, most recently
from
December 2, 2021 10:46
72976e7
to
20b8273
Compare
dapplion
reviewed
Dec 2, 2021
dapplion
reviewed
Dec 5, 2021
dapplion
reviewed
Dec 5, 2021
g11tech
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
December 10, 2021 12:41
g11tech
changed the title
kintsugi optimistic sync
optimistic sync - part 1: track head's execution status and publish/contribute/attest only on non syncing head
Dec 10, 2021
27 tasks
dapplion
changed the title
optimistic sync - part 1: track head's execution status and publish/contribute/attest only on non syncing head
optimistic sync p1 - attest only validated headtrack
Dec 13, 2021
dapplion
changed the title
optimistic sync p1 - attest only validated headtrack
optimistic sync p1 - attest only validated head
Dec 13, 2021
dapplion
reviewed
Dec 15, 2021
dapplion
reviewed
Dec 15, 2021
dapplion
reviewed
Dec 15, 2021
dapplion
previously approved these changes
Dec 15, 2021
dapplion
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a high possibility that EL is syncing while CL asks for execution payloads validation (or preparation in case of publish block).
Optimistic sync is for CL to accept the blocks even when the status is not known (tracked via
payloadStatusUnknown
).However when the calls to EL for executing payload stops responding as syncing, the payloads status/forkchoice needs to be updated
Checklist:
Considered and Rejected
~~-[ ] Fail hard on invalid executePayload call after EL itself prepared payload via getPayload ~~ publishBlock will fail for now, could be escalated later
To be moved to other Task/PR:
Description
UPDATE: working smoothly (producing blocks etc) on a devnet3 node
Closes #3505