Remove requirement to prefix interface with I

[dapplion]

Motivation

In multiple team calls it has been agreed that the rule to prefix all interfaces with I is not productive. While the idea is good it has forced us through the project lifespan to prefix multiple interfaces with I when it was not really necessary. The team can manually request to prefix with I when appropriate.

Description

• Remove requirement to prefix interface with I

[codecov]

Codecov Report

Merging #3900 (2c85678) into master (4311180) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3900   +/-   ##
=======================================
  Coverage   36.64%   36.64%           
=======================================
  Files         324      324           
  Lines        8954     8954           
  Branches     1406     1406           
=======================================
  Hits         3281     3281           
  Misses       5530     5530           
  Partials      143      143           

[github-actions]

Performance Report

✔️ no performance regression detected

Full benchmark results

Benchmark suite	Current: 586c98e	Previous: 4311180	Ratio
BeaconState.hashTreeRoot - No change	386.00 ns/op	389.00 ns/op	0.99
BeaconState.hashTreeRoot - 1 full validator	51.480 us/op	49.908 us/op	1.03
BeaconState.hashTreeRoot - 32 full validator	519.72 us/op	480.82 us/op	1.08
BeaconState.hashTreeRoot - 512 full validator	5.6150 ms/op	5.6173 ms/op	1.00
BeaconState.hashTreeRoot - 1 validator.effectiveBalance	64.510 us/op	61.264 us/op	1.05
BeaconState.hashTreeRoot - 32 validator.effectiveBalance	872.98 us/op	852.26 us/op	1.02
BeaconState.hashTreeRoot - 512 validator.effectiveBalance	12.312 ms/op	12.466 ms/op	0.99
BeaconState.hashTreeRoot - 1 balances	48.940 us/op	46.940 us/op	1.04
BeaconState.hashTreeRoot - 32 balances	443.59 us/op	405.93 us/op	1.09
BeaconState.hashTreeRoot - 512 balances	4.3104 ms/op	4.1374 ms/op	1.04
BeaconState.hashTreeRoot - 250000 balances	91.875 ms/op	96.955 ms/op	0.95
processSlot - 1 slots	9.3910 us/op	9.1460 us/op	1.03
processSlot - 32 slots	1.3925 ms/op	1.6113 ms/op	0.86
getCommitteeAssignments - req 1 vs - 250000 vc	4.7976 ms/op	5.2579 ms/op	0.91
getCommitteeAssignments - req 100 vs - 250000 vc	6.7081 ms/op	7.3026 ms/op	0.92
getCommitteeAssignments - req 1000 vs - 250000 vc	7.3606 ms/op	7.9299 ms/op	0.93
computeProposers - vc 250000	15.269 ms/op	15.724 ms/op	0.97
computeEpochShuffling - vc 250000	148.91 ms/op	146.94 ms/op	1.01
getNextSyncCommittee - vc 250000	257.26 ms/op	282.63 ms/op	0.91
altair processAttestation - 250000 vs - 7PWei normalcase	3.5332 ms/op	4.0515 ms/op	0.87
altair processAttestation - 250000 vs - 7PWei worstcase	5.2905 ms/op	5.5929 ms/op	0.95
altair processAttestation - setStatus - 1/6 committees join	175.60 us/op	204.20 us/op	0.86
altair processAttestation - setStatus - 1/3 committees join	344.20 us/op	348.07 us/op	0.99
altair processAttestation - setStatus - 1/2 committees join	478.82 us/op	536.35 us/op	0.89
altair processAttestation - setStatus - 2/3 committees join	642.27 us/op	684.68 us/op	0.94
altair processAttestation - setStatus - 4/5 committees join	845.70 us/op	983.35 us/op	0.86
altair processAttestation - setStatus - 100% committees join	1.0473 ms/op	1.1387 ms/op	0.92
altair processBlock - 250000 vs - 7PWei normalcase	22.802 ms/op	27.260 ms/op	0.84
altair processBlock - 250000 vs - 7PWei normalcase hashState	32.567 ms/op	39.635 ms/op	0.82
altair processBlock - 250000 vs - 7PWei worstcase	70.180 ms/op	77.303 ms/op	0.91
altair processBlock - 250000 vs - 7PWei worstcase hashState	95.194 ms/op	102.39 ms/op	0.93
altair processEth1Data - 250000 vs - 7PWei normalcase	693.70 us/op	780.79 us/op	0.89
altair processEpoch - mainnet_e81889	462.69 ms/op	568.95 ms/op	0.81
mainnet_e81889 - altair beforeProcessEpoch	135.87 ms/op	168.60 ms/op	0.81
mainnet_e81889 - altair processJustificationAndFinalization	54.807 us/op	34.463 us/op	1.59
mainnet_e81889 - altair processInactivityUpdates	9.3434 ms/op	12.335 ms/op	0.76
mainnet_e81889 - altair processRewardsAndPenalties	130.71 ms/op	141.23 ms/op	0.93
mainnet_e81889 - altair processRegistryUpdates	10.908 us/op	5.3020 us/op	2.06
mainnet_e81889 - altair processSlashings	4.9540 us/op	1.5070 us/op	3.29
mainnet_e81889 - altair processEth1DataReset	4.4670 us/op	1.2310 us/op	3.63
mainnet_e81889 - altair processEffectiveBalanceUpdates	6.4300 ms/op	6.9037 ms/op	0.93
mainnet_e81889 - altair processSlashingsReset	15.023 us/op	7.3910 us/op	2.03
mainnet_e81889 - altair processRandaoMixesReset	13.768 us/op	9.6080 us/op	1.43
mainnet_e81889 - altair processHistoricalRootsUpdate	4.3750 us/op	2.5580 us/op	1.71
mainnet_e81889 - altair processParticipationFlagUpdates	8.0290 us/op	4.8130 us/op	1.67
mainnet_e81889 - altair processSyncCommitteeUpdates	3.5210 us/op	1.9180 us/op	1.84
mainnet_e81889 - altair afterProcessEpoch	205.22 ms/op	188.67 ms/op	1.09
altair processInactivityUpdates - 250000 normalcase	29.700 ms/op	41.368 ms/op	0.72
altair processInactivityUpdates - 250000 worstcase	24.575 ms/op	32.945 ms/op	0.75
altair processRewardsAndPenalties - 250000 normalcase	128.12 ms/op	91.501 ms/op	1.40
altair processRewardsAndPenalties - 250000 worstcase	110.80 ms/op	87.509 ms/op	1.27
altair processSyncCommitteeUpdates - 250000	281.07 ms/op	286.58 ms/op	0.98
Tree 40 250000 create	612.34 ms/op	851.63 ms/op	0.72
Tree 40 250000 get(125000)	280.60 ns/op	260.64 ns/op	1.08
Tree 40 250000 set(125000)	2.0260 us/op	2.3301 us/op	0.87
Tree 40 250000 toArray()	28.743 ms/op	35.986 ms/op	0.80
Tree 40 250000 iterate all - toArray() + loop	30.698 ms/op	36.379 ms/op	0.84
Tree 40 250000 iterate all - get(i)	104.44 ms/op	106.02 ms/op	0.99
MutableVector 250000 create	15.301 ms/op	17.128 ms/op	0.89
MutableVector 250000 get(125000)	13.404 ns/op	13.114 ns/op	1.02
MutableVector 250000 set(125000)	534.84 ns/op	736.53 ns/op	0.73
MutableVector 250000 toArray()	6.0013 ms/op	7.7844 ms/op	0.77
MutableVector 250000 iterate all - toArray() + loop	6.0772 ms/op	7.9751 ms/op	0.76
MutableVector 250000 iterate all - get(i)	3.4975 ms/op	2.8994 ms/op	1.21
Array 250000 create	5.6063 ms/op	7.6141 ms/op	0.74
Array 250000 clone - spread	2.7013 ms/op	2.8057 ms/op	0.96
Array 250000 get(125000)	1.2030 ns/op	1.2340 ns/op	0.97
Array 250000 set(125000)	1.2170 ns/op	1.2490 ns/op	0.97
Array 250000 iterate all - loop	165.61 us/op	167.85 us/op	0.99
effectiveBalanceIncrements clone Uint8Array 300000	57.667 us/op	278.37 us/op	0.21
effectiveBalanceIncrements clone MutableVector 300000	555.00 ns/op	495.00 ns/op	1.12
effectiveBalanceIncrements rw all Uint8Array 300000	290.23 us/op	266.49 us/op	1.09
effectiveBalanceIncrements rw all MutableVector 300000	142.43 ms/op	184.69 ms/op	0.77
aggregationBits - 2048 els - zipIndexesInBitList	22.718 us/op	27.725 us/op	0.82
regular array get 100000 times	64.984 us/op	59.611 us/op	1.09
wrappedArray get 100000 times	66.998 us/op	59.583 us/op	1.12
arrayWithProxy get 100000 times	31.836 ms/op	29.958 ms/op	1.06
ssz.Root.equals	424.00 ns/op	430.00 ns/op	0.99
byteArrayEquals	375.00 ns/op	416.00 ns/op	0.90
phase0 processBlock - 250000 vs - 7PWei normalcase	3.2805 ms/op	3.6536 ms/op	0.90
phase0 processBlock - 250000 vs - 7PWei worstcase	43.989 ms/op	43.121 ms/op	1.02
phase0 afterProcessEpoch - 250000 vs - 7PWei	173.63 ms/op	161.87 ms/op	1.07
phase0 beforeProcessEpoch - 250000 vs - 7PWei	73.496 ms/op	96.742 ms/op	0.76
phase0 processEpoch - mainnet_e58758	532.13 ms/op	612.28 ms/op	0.87
mainnet_e58758 - phase0 beforeProcessEpoch	230.36 ms/op	281.54 ms/op	0.82
mainnet_e58758 - phase0 processJustificationAndFinalization	39.758 us/op	35.631 us/op	1.12
mainnet_e58758 - phase0 processRewardsAndPenalties	116.54 ms/op	116.05 ms/op	1.00
mainnet_e58758 - phase0 processRegistryUpdates	25.963 us/op	12.361 us/op	2.10
mainnet_e58758 - phase0 processSlashings	4.6890 us/op	2.0740 us/op	2.26
mainnet_e58758 - phase0 processEth1DataReset	4.8830 us/op	1.9040 us/op	2.56
mainnet_e58758 - phase0 processEffectiveBalanceUpdates	5.1629 ms/op	5.6956 ms/op	0.91
mainnet_e58758 - phase0 processSlashingsReset	21.238 us/op	9.1580 us/op	2.32
mainnet_e58758 - phase0 processRandaoMixesReset	18.853 us/op	11.079 us/op	1.70
mainnet_e58758 - phase0 processHistoricalRootsUpdate	6.5730 us/op	2.3840 us/op	2.76
mainnet_e58758 - phase0 processParticipationRecordUpdates	14.654 us/op	10.189 us/op	1.44
mainnet_e58758 - phase0 afterProcessEpoch	153.05 ms/op	143.43 ms/op	1.07
phase0 processEffectiveBalanceUpdates - 250000 normalcase	6.3749 ms/op	5.8552 ms/op	1.09
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5	6.6334 ms/op	6.1728 ms/op	1.07
phase0 processRegistryUpdates - 250000 normalcase	25.084 us/op	11.749 us/op	2.13
phase0 processRegistryUpdates - 250000 badcase_full_deposits	635.23 us/op	382.29 us/op	1.66
phase0 processRegistryUpdates - 250000 worstcase 0.5	203.17 ms/op	253.41 ms/op	0.80
phase0 getAttestationDeltas - 250000 normalcase	13.529 ms/op	17.285 ms/op	0.78
phase0 getAttestationDeltas - 250000 worstcase	13.697 ms/op	17.348 ms/op	0.79
phase0 processSlashings - 250000 worstcase	5.3508 ms/op	5.6920 ms/op	0.94
shuffle list - 16384 els	9.8360 ms/op	10.788 ms/op	0.91
shuffle list - 250000 els	142.26 ms/op	154.69 ms/op	0.92
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei	337.28 us/op	409.98 us/op	0.82
pass gossip attestations to forkchoice per slot	4.6062 ms/op	3.5802 ms/op	1.29
computeDeltas	3.3486 ms/op	3.9062 ms/op	0.86
computeProposerBoostScoreFromBalances	486.04 us/op	502.87 us/op	0.97
getPubkeys - index2pubkey - req 1000 vs - 250000 vc	1.8445 ms/op	2.6951 ms/op	0.68
getPubkeys - validatorsArr - req 1000 vs - 250000 vc	67.183 us/op	80.629 us/op	0.83
BLS verify - blst-native	1.7481 ms/op	1.8592 ms/op	0.94
BLS verifyMultipleSignatures 3 - blst-native	3.5138 ms/op	3.8126 ms/op	0.92
BLS verifyMultipleSignatures 8 - blst-native	7.6379 ms/op	8.2014 ms/op	0.93
BLS verifyMultipleSignatures 32 - blst-native	28.323 ms/op	29.722 ms/op	0.95
BLS aggregatePubkeys 32 - blst-native	36.753 us/op	35.833 us/op	1.03
BLS aggregatePubkeys 128 - blst-native	147.44 us/op	134.48 us/op	1.10
getAttestationsForBlock	49.393 ms/op	60.572 ms/op	0.82
CheckpointStateCache - add get delete	9.4020 us/op	11.259 us/op	0.84
validate gossip signedAggregateAndProof - struct	4.0658 ms/op	4.2652 ms/op	0.95
validate gossip attestation - struct	1.8837 ms/op	2.0437 ms/op	0.92
pickEth1Vote - no votes	1.9515 ms/op	2.3100 ms/op	0.84
pickEth1Vote - max votes	16.758 ms/op	23.209 ms/op	0.72
pickEth1Vote - Eth1Data hashTreeRoot value x2048	11.194 ms/op	12.275 ms/op	0.91
pickEth1Vote - Eth1Data hashTreeRoot tree x2048	18.996 ms/op	22.264 ms/op	0.85
pickEth1Vote - Eth1Data fastSerialize value x2048	1.5743 ms/op	1.5672 ms/op	1.00
pickEth1Vote - Eth1Data fastSerialize tree x2048	11.341 ms/op	13.957 ms/op	0.81
bytes32 toHexString	906.00 ns/op	934.00 ns/op	0.97
bytes32 Buffer.toString(hex)	640.00 ns/op	645.00 ns/op	0.99
bytes32 Buffer.toString(hex) from Uint8Array	807.00 ns/op	876.00 ns/op	0.92
bytes32 Buffer.toString(hex) + 0x	658.00 ns/op	652.00 ns/op	1.01
Object access 1 prop	0.29500 ns/op	0.33300 ns/op	0.89
Map access 1 prop	0.28000 ns/op	0.27000 ns/op	1.04
Object get x1000	16.293 ns/op	14.831 ns/op	1.10
Map get x1000	1.0390 ns/op	0.88800 ns/op	1.17
Object set x1000	91.420 ns/op	117.44 ns/op	0.78
Map set x1000	55.647 ns/op	72.554 ns/op	0.77
Return object 10000 times	0.34370 ns/op	0.32950 ns/op	1.04
Throw Error 10000 times	5.4237 us/op	5.2721 us/op	1.03
enrSubnets - fastDeserialize 64 bits	794.00 ns/op	1.0490 us/op	0.76
enrSubnets - ssz BitVector 64 bits	541.00 ns/op	582.00 ns/op	0.93
enrSubnets - fastDeserialize 4 bits	387.00 ns/op	413.00 ns/op	0.94
enrSubnets - ssz BitVector 4 bits	556.00 ns/op	561.00 ns/op	0.99
RateTracker 1000000 limit, 1 obj count per request	161.38 ns/op	171.32 ns/op	0.94
RateTracker 1000000 limit, 2 obj count per request	119.33 ns/op	129.49 ns/op	0.92
RateTracker 1000000 limit, 4 obj count per request	100.67 ns/op	107.92 ns/op	0.93
RateTracker 1000000 limit, 8 obj count per request	88.094 ns/op	98.047 ns/op	0.90
RateTracker with prune	3.2420 us/op	4.3760 us/op	0.74
array of 16000 items push then shift	2.9306 us/op	2.7842 us/op	1.05
LinkedList of 16000 items push then shift	16.208 ns/op	19.836 ns/op	0.82
array of 16000 items push then pop	197.41 ns/op	255.44 ns/op	0.77
LinkedList of 16000 items push then pop	15.019 ns/op	17.956 ns/op	0.84
array of 24000 items push then shift	4.4072 us/op	4.6180 us/op	0.95
LinkedList of 24000 items push then shift	17.415 ns/op	26.493 ns/op	0.66
array of 24000 items push then pop	175.38 ns/op	219.80 ns/op	0.80
LinkedList of 24000 items push then pop	16.315 ns/op	21.502 ns/op	0.76

by benchmarkbot/action