Cache and reuse old validator registration data if no params change #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
changed the title
Performance Report✔️ no performance regression detected Full benchmark results
|
6 tasks
g11tech
force-pushed
the
g11tech/reuse-builder-val-reg
branch
from
dd82d4e to
ad96cfd
Compare
wemeetagain
reviewed
Aug 25, 2022
| @@ -79,6 +80,8 @@ type ValidatorData = { | |||
| */ | |||
| export class ValidatorStore { | |||
| private readonly validators = new Map<PubkeyHex, ValidatorData>(); | |||
| private readonly validatorRegistrationCache = new ValidatorRegistrationCache(); | |||
There was a problem hiding this comment.
Can you include a jsdoc comment here or on the class?
There was a problem hiding this comment.
Why not add this inside ValidatorData so it gets automatically pruned when removing validators?
twoeths
reviewed
Aug 26, 2022
| fromHexString(feeRecipient), | ||
| slot | ||
| ); | ||
| return validatorStore.getValidatorRegistration(pubkeyHex, feeRecipient, slot); |
There was a problem hiding this comment.
the FB team requested not to create/send new registration objects unless params change.
@g11tech I still see we send every validator registration per epoch, is it expected?
There was a problem hiding this comment.
yes, they also only keep a registration for 2 epochs, so its recommended to refresh every epoch 👍
dapplion
reviewed
Aug 29, 2022
| export class ValidatorRegistrationCache { | ||
| private readonly validatorRegistrationMap = new Map< | ||
| string, | ||
| {validatorRegistration: bellatrix.SignedValidatorRegistrationV1; fullKey: string} |
There was a problem hiding this comment.
Add alias on type string such that
type PubkeyHex = string
/** `${feeRecipient}-${gasLimit}` */
type AttributesKey = stringThere was a problem hiding this comment.
Since fullKey is nested by first level of pubkey, does it really need to include the pubkey?
There was a problem hiding this comment.
If you add this cache inside ValidatorData you don't need the 2d Map. And then you can prune by number of attribute combinations which is what makes more sense. pubkeys are naturally bounded already
g11tech
force-pushed
the
g11tech/reuse-builder-val-reg
branch
from
d8c06d3 to
45fab0b
Compare
wemeetagain
previously approved these changes
Sep 2, 2022
wemeetagain
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The FB team requested not to create/send new registration objects unless params change.
This PR caches the registration objects and reuses them to register them to builder.
Reference: