Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unrelated code cleanup #5989

Merged
merged 6 commits into from
Sep 23, 2023
Merged

chore: unrelated code cleanup #5989

merged 6 commits into from
Sep 23, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Sep 23, 2023

Motivation

Few unrelated code cleanup changes I had stashed for a while

Description

Unrelated code cleanup, see commits for details

@nflaig nflaig requested a review from a team as a code owner September 23, 2023 14:44
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 43c80e6 Previous: 9618dd1 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 699.67 us/op 814.25 us/op 0.86
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 74.271 us/op 109.28 us/op 0.68
BLS verify - blst-native 1.2683 ms/op 1.3630 ms/op 0.93
BLS verifyMultipleSignatures 3 - blst-native 2.6864 ms/op 2.8415 ms/op 0.95
BLS verifyMultipleSignatures 8 - blst-native 5.8368 ms/op 6.2390 ms/op 0.94
BLS verifyMultipleSignatures 32 - blst-native 21.312 ms/op 22.847 ms/op 0.93
BLS verifyMultipleSignatures 64 - blst-native 41.967 ms/op 44.905 ms/op 0.93
BLS verifyMultipleSignatures 128 - blst-native 83.417 ms/op 88.396 ms/op 0.94
BLS deserializing 10000 signatures 860.57 ms/op 918.63 ms/op 0.94
BLS deserializing 100000 signatures 8.6396 s/op 9.1709 s/op 0.94
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3714 ms/op 1.3601 ms/op 1.01
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.4345 ms/op 1.6123 ms/op 0.89
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.2168 ms/op 2.3412 ms/op 0.95
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.3517 ms/op 3.5001 ms/op 0.96
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.4840 ms/op 5.6960 ms/op 0.96
BLS aggregatePubkeys 32 - blst-native 24.991 us/op 26.000 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 98.321 us/op 102.50 us/op 0.96
getAttestationsForBlock 32.395 ms/op 44.286 ms/op 0.73
isKnown best case - 1 super set check 262.00 ns/op 360.00 ns/op 0.73
isKnown normal case - 2 super set checks 256.00 ns/op 453.00 ns/op 0.57
isKnown worse case - 16 super set checks 254.00 ns/op 441.00 ns/op 0.58
CheckpointStateCache - add get delete 4.7600 us/op 5.6820 us/op 0.84
validate api signedAggregateAndProof - struct 2.6318 ms/op 2.8749 ms/op 0.92
validate gossip signedAggregateAndProof - struct 2.6402 ms/op 2.8623 ms/op 0.92
validate gossip attestation - vc 640000 1.2970 ms/op 1.3890 ms/op 0.93
batch validate gossip attestation - vc 640000 - chunk 32 151.83 us/op 173.12 us/op 0.88
batch validate gossip attestation - vc 640000 - chunk 64 137.80 us/op 150.93 us/op 0.91
batch validate gossip attestation - vc 640000 - chunk 128 133.53 us/op 140.69 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 256 128.10 us/op 142.18 us/op 0.90
pickEth1Vote - no votes 1.1392 ms/op 1.5193 ms/op 0.75
pickEth1Vote - max votes 11.084 ms/op 11.269 ms/op 0.98
pickEth1Vote - Eth1Data hashTreeRoot value x2048 16.774 ms/op 19.651 ms/op 0.85
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.917 ms/op 30.533 ms/op 0.75
pickEth1Vote - Eth1Data fastSerialize value x2048 559.04 us/op 680.83 us/op 0.82
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.0776 ms/op 7.3031 ms/op 0.70
bytes32 toHexString 450.00 ns/op 603.00 ns/op 0.75
bytes32 Buffer.toString(hex) 283.00 ns/op 319.00 ns/op 0.89
bytes32 Buffer.toString(hex) from Uint8Array 433.00 ns/op 531.00 ns/op 0.82
bytes32 Buffer.toString(hex) + 0x 281.00 ns/op 341.00 ns/op 0.82
Object access 1 prop 0.14600 ns/op 0.20800 ns/op 0.70
Map access 1 prop 0.14400 ns/op 0.17300 ns/op 0.83
Object get x1000 7.1640 ns/op 9.4670 ns/op 0.76
Map get x1000 0.59300 ns/op 0.79500 ns/op 0.75
Object set x1000 48.314 ns/op 65.441 ns/op 0.74
Map set x1000 37.894 ns/op 48.273 ns/op 0.78
Return object 10000 times 0.23720 ns/op 0.26940 ns/op 0.88
Throw Error 10000 times 3.7921 us/op 3.9723 us/op 0.95
fastMsgIdFn sha256 / 200 bytes 3.3500 us/op 3.4790 us/op 0.96
fastMsgIdFn h32 xxhash / 200 bytes 300.00 ns/op 320.00 ns/op 0.94
fastMsgIdFn h64 xxhash / 200 bytes 367.00 ns/op 379.00 ns/op 0.97
fastMsgIdFn sha256 / 1000 bytes 11.616 us/op 12.141 us/op 0.96
fastMsgIdFn h32 xxhash / 1000 bytes 434.00 ns/op 492.00 ns/op 0.88
fastMsgIdFn h64 xxhash / 1000 bytes 442.00 ns/op 465.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 106.04 us/op 107.88 us/op 0.98
fastMsgIdFn h32 xxhash / 10000 bytes 2.0100 us/op 2.0480 us/op 0.98
fastMsgIdFn h64 xxhash / 10000 bytes 1.4140 us/op 1.4360 us/op 0.98
send data - 1000 256B messages 19.633 ms/op 19.762 ms/op 0.99
send data - 1000 512B messages 27.431 ms/op 28.649 ms/op 0.96
send data - 1000 1024B messages 42.364 ms/op 43.309 ms/op 0.98
send data - 1000 1200B messages 30.216 ms/op 33.923 ms/op 0.89
send data - 1000 2048B messages 29.866 ms/op 37.596 ms/op 0.79
send data - 1000 4096B messages 32.667 ms/op 33.552 ms/op 0.97
send data - 1000 16384B messages 75.030 ms/op 82.468 ms/op 0.91
send data - 1000 65536B messages 272.15 ms/op 297.83 ms/op 0.91
enrSubnets - fastDeserialize 64 bits 1.1500 us/op 1.3360 us/op 0.86
enrSubnets - ssz BitVector 64 bits 401.00 ns/op 457.00 ns/op 0.88
enrSubnets - fastDeserialize 4 bits 161.00 ns/op 177.00 ns/op 0.91
enrSubnets - ssz BitVector 4 bits 396.00 ns/op 502.00 ns/op 0.79
prioritizePeers score -10:0 att 32-0.1 sync 2-0 98.661 us/op 110.17 us/op 0.90
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 115.05 us/op 137.54 us/op 0.84
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 152.93 us/op 182.31 us/op 0.84
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 272.52 us/op 323.17 us/op 0.84
prioritizePeers score 0:0 att 64-1 sync 4-1 320.11 us/op 384.16 us/op 0.83
array of 16000 items push then shift 1.5749 us/op 1.8330 us/op 0.86
LinkedList of 16000 items push then shift 8.7870 ns/op 11.870 ns/op 0.74
array of 16000 items push then pop 70.411 ns/op 105.38 ns/op 0.67
LinkedList of 16000 items push then pop 8.5380 ns/op 10.157 ns/op 0.84
array of 24000 items push then shift 2.3288 us/op 2.8087 us/op 0.83
LinkedList of 24000 items push then shift 8.7240 ns/op 11.516 ns/op 0.76
array of 24000 items push then pop 90.124 ns/op 148.30 ns/op 0.61
LinkedList of 24000 items push then pop 8.2960 ns/op 9.9900 ns/op 0.83
intersect bitArray bitLen 8 6.5280 ns/op 7.2940 ns/op 0.89
intersect array and set length 8 51.093 ns/op 77.285 ns/op 0.66
intersect bitArray bitLen 128 30.542 ns/op 33.956 ns/op 0.90
intersect array and set length 128 714.68 ns/op 990.58 ns/op 0.72
bitArray.getTrueBitIndexes() bitLen 128 1.4250 us/op 1.8710 us/op 0.76
bitArray.getTrueBitIndexes() bitLen 248 2.3330 us/op 3.0380 us/op 0.77
bitArray.getTrueBitIndexes() bitLen 512 4.4360 us/op 6.3670 us/op 0.70
Buffer.concat 32 items 939.00 ns/op 1.1200 us/op 0.84
Uint8Array.set 32 items 2.3290 us/op 2.1630 us/op 1.08
Set add up to 64 items then delete first 4.0905 us/op 4.9342 us/op 0.83
OrderedSet add up to 64 items then delete first 5.1377 us/op 6.4115 us/op 0.80
Set add up to 64 items then delete last 4.3922 us/op 5.2377 us/op 0.84
OrderedSet add up to 64 items then delete last 5.4915 us/op 6.8059 us/op 0.81
Set add up to 64 items then delete middle 4.3897 us/op 5.2434 us/op 0.84
OrderedSet add up to 64 items then delete middle 6.6679 us/op 8.2281 us/op 0.81
Set add up to 128 items then delete first 8.9549 us/op 10.718 us/op 0.84
OrderedSet add up to 128 items then delete first 11.685 us/op 14.845 us/op 0.79
Set add up to 128 items then delete last 8.8113 us/op 10.670 us/op 0.83
OrderedSet add up to 128 items then delete last 11.086 us/op 13.819 us/op 0.80
Set add up to 128 items then delete middle 8.6890 us/op 10.516 us/op 0.83
OrderedSet add up to 128 items then delete middle 16.074 us/op 19.381 us/op 0.83
Set add up to 256 items then delete first 18.183 us/op 21.584 us/op 0.84
OrderedSet add up to 256 items then delete first 24.003 us/op 29.386 us/op 0.82
Set add up to 256 items then delete last 17.554 us/op 20.613 us/op 0.85
OrderedSet add up to 256 items then delete last 22.467 us/op 25.892 us/op 0.87
Set add up to 256 items then delete middle 17.425 us/op 20.589 us/op 0.85
OrderedSet add up to 256 items then delete middle 43.037 us/op 51.636 us/op 0.83
transfer serialized Status (84 B) 1.8520 us/op 1.8740 us/op 0.99
copy serialized Status (84 B) 1.5180 us/op 1.5680 us/op 0.97
transfer serialized SignedVoluntaryExit (112 B) 2.1090 us/op 2.1800 us/op 0.97
copy serialized SignedVoluntaryExit (112 B) 1.6820 us/op 1.7150 us/op 0.98
transfer serialized ProposerSlashing (416 B) 3.1060 us/op 3.1160 us/op 1.00
copy serialized ProposerSlashing (416 B) 2.8940 us/op 2.4560 us/op 1.18
transfer serialized Attestation (485 B) 3.1850 us/op 2.3640 us/op 1.35
copy serialized Attestation (485 B) 2.9040 us/op 2.0840 us/op 1.39
transfer serialized AttesterSlashing (33232 B) 2.9980 us/op 2.2330 us/op 1.34
copy serialized AttesterSlashing (33232 B) 5.6880 us/op 5.8190 us/op 0.98
transfer serialized Small SignedBeaconBlock (128000 B) 3.1170 us/op 2.5800 us/op 1.21
copy serialized Small SignedBeaconBlock (128000 B) 12.285 us/op 14.904 us/op 0.82
transfer serialized Avg SignedBeaconBlock (200000 B) 3.4450 us/op 2.9530 us/op 1.17
copy serialized Avg SignedBeaconBlock (200000 B) 16.806 us/op 20.919 us/op 0.80
transfer serialized BlobsSidecar (524380 B) 2.9820 us/op 2.7180 us/op 1.10
copy serialized BlobsSidecar (524380 B) 78.990 us/op 86.580 us/op 0.91
transfer serialized Big SignedBeaconBlock (1000000 B) 3.2160 us/op 2.9480 us/op 1.09
copy serialized Big SignedBeaconBlock (1000000 B) 150.64 us/op 155.85 us/op 0.97
pass gossip attestations to forkchoice per slot 3.7159 ms/op 3.9264 ms/op 0.95
forkChoice updateHead vc 100000 bc 64 eq 0 659.79 us/op 704.12 us/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 0 4.4709 ms/op 5.4246 ms/op 0.82
forkChoice updateHead vc 1000000 bc 64 eq 0 7.1189 ms/op 7.4188 ms/op 0.96
forkChoice updateHead vc 600000 bc 320 eq 0 4.1001 ms/op 4.3828 ms/op 0.94
forkChoice updateHead vc 600000 bc 1200 eq 0 4.1086 ms/op 4.4126 ms/op 0.93
forkChoice updateHead vc 600000 bc 7200 eq 0 5.2433 ms/op 5.2476 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 1000 10.940 ms/op 11.350 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 10000 11.915 ms/op 12.399 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 300000 15.375 ms/op 16.835 ms/op 0.91
computeDeltas 500000 validators 300 proto nodes 6.1797 ms/op 6.3579 ms/op 0.97
computeDeltas 500000 validators 1200 proto nodes 6.1553 ms/op 6.3056 ms/op 0.98
computeDeltas 500000 validators 7200 proto nodes 6.0554 ms/op 6.2615 ms/op 0.97
computeDeltas 750000 validators 300 proto nodes 9.1754 ms/op 9.4485 ms/op 0.97
computeDeltas 750000 validators 1200 proto nodes 9.1527 ms/op 9.4529 ms/op 0.97
computeDeltas 750000 validators 7200 proto nodes 9.1892 ms/op 9.5841 ms/op 0.96
computeDeltas 1400000 validators 300 proto nodes 17.133 ms/op 18.846 ms/op 0.91
computeDeltas 1400000 validators 1200 proto nodes 17.055 ms/op 24.066 ms/op 0.71
computeDeltas 1400000 validators 7200 proto nodes 17.350 ms/op 18.752 ms/op 0.93
computeDeltas 2100000 validators 300 proto nodes 26.385 ms/op 30.066 ms/op 0.88
computeDeltas 2100000 validators 1200 proto nodes 25.831 ms/op 32.135 ms/op 0.80
computeDeltas 2100000 validators 7200 proto nodes 26.001 ms/op 32.038 ms/op 0.81
computeProposerBoostScoreFromBalances 500000 validators 3.1323 ms/op 4.2541 ms/op 0.74
computeProposerBoostScoreFromBalances 750000 validators 3.0915 ms/op 4.1316 ms/op 0.75
computeProposerBoostScoreFromBalances 1400000 validators 3.0839 ms/op 4.1514 ms/op 0.74
computeProposerBoostScoreFromBalances 2100000 validators 3.1261 ms/op 4.1921 ms/op 0.75
altair processAttestation - 250000 vs - 7PWei normalcase 2.5218 ms/op 4.5945 ms/op 0.55
altair processAttestation - 250000 vs - 7PWei worstcase 3.1009 ms/op 5.9816 ms/op 0.52
altair processAttestation - setStatus - 1/6 committees join 168.64 us/op 290.31 us/op 0.58
altair processAttestation - setStatus - 1/3 committees join 327.49 us/op 538.54 us/op 0.61
altair processAttestation - setStatus - 1/2 committees join 442.91 us/op 742.67 us/op 0.60
altair processAttestation - setStatus - 2/3 committees join 560.40 us/op 1.0453 ms/op 0.54
altair processAttestation - setStatus - 4/5 committees join 736.25 us/op 1.5646 ms/op 0.47
altair processAttestation - setStatus - 100% committees join 870.37 us/op 1.7582 ms/op 0.50
altair processBlock - 250000 vs - 7PWei normalcase 7.1485 ms/op 11.524 ms/op 0.62
altair processBlock - 250000 vs - 7PWei normalcase hashState 31.590 ms/op 50.702 ms/op 0.62
altair processBlock - 250000 vs - 7PWei worstcase 39.260 ms/op 51.292 ms/op 0.77
altair processBlock - 250000 vs - 7PWei worstcase hashState 86.621 ms/op 126.50 ms/op 0.68
phase0 processBlock - 250000 vs - 7PWei normalcase 2.5086 ms/op 3.9418 ms/op 0.64
phase0 processBlock - 250000 vs - 7PWei worstcase 29.402 ms/op 41.416 ms/op 0.71
altair processEth1Data - 250000 vs - 7PWei normalcase 473.16 us/op 806.05 us/op 0.59
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 11.386 us/op 25.822 us/op 0.44
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 61.856 us/op 88.959 us/op 0.70
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 14.397 us/op 28.374 us/op 0.51
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 10.955 us/op 24.124 us/op 0.45
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 157.47 us/op 226.39 us/op 0.70
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0334 ms/op 2.2306 ms/op 0.46
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.5037 ms/op 2.4064 ms/op 0.62
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.5574 ms/op 2.4304 ms/op 0.64
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.7835 ms/op 5.9644 ms/op 0.63
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.2618 ms/op 4.2178 ms/op 0.54
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.0276 ms/op 10.601 ms/op 0.47
Tree 40 250000 create 297.79 ms/op 790.76 ms/op 0.38
Tree 40 250000 get(125000) 196.47 ns/op 250.28 ns/op 0.78
Tree 40 250000 set(125000) 862.46 ns/op 2.5086 us/op 0.34
Tree 40 250000 toArray() 17.710 ms/op 39.627 ms/op 0.45
Tree 40 250000 iterate all - toArray() + loop 18.609 ms/op 32.710 ms/op 0.57
Tree 40 250000 iterate all - get(i) 69.916 ms/op 87.468 ms/op 0.80
MutableVector 250000 create 12.161 ms/op 21.337 ms/op 0.57
MutableVector 250000 get(125000) 6.4090 ns/op 7.6050 ns/op 0.84
MutableVector 250000 set(125000) 254.39 ns/op 496.28 ns/op 0.51
MutableVector 250000 toArray() 3.0753 ms/op 5.3180 ms/op 0.58
MutableVector 250000 iterate all - toArray() + loop 3.2077 ms/op 4.9952 ms/op 0.64
MutableVector 250000 iterate all - get(i) 1.5337 ms/op 1.8371 ms/op 0.83
Array 250000 create 2.9725 ms/op 4.5527 ms/op 0.65
Array 250000 clone - spread 959.73 us/op 1.7392 ms/op 0.55
Array 250000 get(125000) 0.48300 ns/op 1.0610 ns/op 0.46
Array 250000 set(125000) 0.55400 ns/op 1.1780 ns/op 0.47
Array 250000 iterate all - loop 81.269 us/op 95.757 us/op 0.85
effectiveBalanceIncrements clone Uint8Array 300000 20.630 us/op 57.477 us/op 0.36
effectiveBalanceIncrements clone MutableVector 300000 255.00 ns/op 455.00 ns/op 0.56
effectiveBalanceIncrements rw all Uint8Array 300000 176.79 us/op 198.32 us/op 0.89
effectiveBalanceIncrements rw all MutableVector 300000 73.630 ms/op 163.85 ms/op 0.45
phase0 afterProcessEpoch - 250000 vs - 7PWei 111.49 ms/op 143.48 ms/op 0.78
phase0 beforeProcessEpoch - 250000 vs - 7PWei 36.257 ms/op 59.538 ms/op 0.61
altair processEpoch - mainnet_e81889 454.61 ms/op 665.07 ms/op 0.68
mainnet_e81889 - altair beforeProcessEpoch 48.676 ms/op 108.50 ms/op 0.45
mainnet_e81889 - altair processJustificationAndFinalization 13.396 us/op 34.756 us/op 0.39
mainnet_e81889 - altair processInactivityUpdates 5.9706 ms/op 14.014 ms/op 0.43
mainnet_e81889 - altair processRewardsAndPenalties 51.857 ms/op 87.327 ms/op 0.59
mainnet_e81889 - altair processRegistryUpdates 2.1950 us/op 8.5140 us/op 0.26
mainnet_e81889 - altair processSlashings 437.00 ns/op 1.4210 us/op 0.31
mainnet_e81889 - altair processEth1DataReset 530.00 ns/op 1.3370 us/op 0.40
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2548 ms/op 1.8430 ms/op 0.68
mainnet_e81889 - altair processSlashingsReset 2.8450 us/op 9.3710 us/op 0.30
mainnet_e81889 - altair processRandaoMixesReset 3.9770 us/op 11.288 us/op 0.35
mainnet_e81889 - altair processHistoricalRootsUpdate 543.00 ns/op 1.8550 us/op 0.29
mainnet_e81889 - altair processParticipationFlagUpdates 1.7020 us/op 6.2810 us/op 0.27
mainnet_e81889 - altair processSyncCommitteeUpdates 532.00 ns/op 2.0950 us/op 0.25
mainnet_e81889 - altair afterProcessEpoch 120.46 ms/op 165.05 ms/op 0.73
capella processEpoch - mainnet_e217614 1.4289 s/op 2.0508 s/op 0.70
mainnet_e217614 - capella beforeProcessEpoch 225.28 ms/op 351.50 ms/op 0.64
mainnet_e217614 - capella processJustificationAndFinalization 12.698 us/op 33.460 us/op 0.38
mainnet_e217614 - capella processInactivityUpdates 18.267 ms/op 34.725 ms/op 0.53
mainnet_e217614 - capella processRewardsAndPenalties 253.92 ms/op 357.13 ms/op 0.71
mainnet_e217614 - capella processRegistryUpdates 17.029 us/op 39.240 us/op 0.43
mainnet_e217614 - capella processSlashings 485.00 ns/op 1.6660 us/op 0.29
mainnet_e217614 - capella processEth1DataReset 620.00 ns/op 1.3560 us/op 0.46
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.0337 ms/op 6.1357 ms/op 0.66
mainnet_e217614 - capella processSlashingsReset 3.0400 us/op 8.8380 us/op 0.34
mainnet_e217614 - capella processRandaoMixesReset 4.2610 us/op 11.478 us/op 0.37
mainnet_e217614 - capella processHistoricalRootsUpdate 616.00 ns/op 1.6760 us/op 0.37
mainnet_e217614 - capella processParticipationFlagUpdates 1.5100 us/op 7.2050 us/op 0.21
mainnet_e217614 - capella afterProcessEpoch 294.14 ms/op 421.97 ms/op 0.70
phase0 processEpoch - mainnet_e58758 432.63 ms/op 691.03 ms/op 0.63
mainnet_e58758 - phase0 beforeProcessEpoch 116.61 ms/op 199.65 ms/op 0.58
mainnet_e58758 - phase0 processJustificationAndFinalization 16.095 us/op 34.067 us/op 0.47
mainnet_e58758 - phase0 processRewardsAndPenalties 42.283 ms/op 58.271 ms/op 0.73
mainnet_e58758 - phase0 processRegistryUpdates 12.428 us/op 23.074 us/op 0.54
mainnet_e58758 - phase0 processSlashings 504.00 ns/op 1.5250 us/op 0.33
mainnet_e58758 - phase0 processEth1DataReset 529.00 ns/op 1.3960 us/op 0.38
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0631 ms/op 1.8898 ms/op 0.56
mainnet_e58758 - phase0 processSlashingsReset 2.2140 us/op 6.6700 us/op 0.33
mainnet_e58758 - phase0 processRandaoMixesReset 5.4480 us/op 11.969 us/op 0.46
mainnet_e58758 - phase0 processHistoricalRootsUpdate 591.00 ns/op 1.3700 us/op 0.43
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.1940 us/op 13.241 us/op 0.39
mainnet_e58758 - phase0 afterProcessEpoch 101.87 ms/op 146.46 ms/op 0.70
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9415 ms/op 2.2265 ms/op 0.87
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4569 ms/op 2.1124 ms/op 0.69
altair processInactivityUpdates - 250000 normalcase 19.891 ms/op 31.877 ms/op 0.62
altair processInactivityUpdates - 250000 worstcase 20.082 ms/op 35.846 ms/op 0.56
phase0 processRegistryUpdates - 250000 normalcase 11.171 us/op 25.659 us/op 0.44
phase0 processRegistryUpdates - 250000 badcase_full_deposits 356.31 us/op 540.09 us/op 0.66
phase0 processRegistryUpdates - 250000 worstcase 0.5 133.39 ms/op 260.53 ms/op 0.51
altair processRewardsAndPenalties - 250000 normalcase 63.545 ms/op 63.438 ms/op 1.00
altair processRewardsAndPenalties - 250000 worstcase 65.447 ms/op 78.232 ms/op 0.84
phase0 getAttestationDeltas - 250000 normalcase 7.8489 ms/op 12.105 ms/op 0.65
phase0 getAttestationDeltas - 250000 worstcase 8.3864 ms/op 13.690 ms/op 0.61
phase0 processSlashings - 250000 worstcase 2.4065 ms/op 3.9747 ms/op 0.61
altair processSyncCommitteeUpdates - 250000 162.28 ms/op 232.80 ms/op 0.70
BeaconState.hashTreeRoot - No change 321.00 ns/op 483.00 ns/op 0.66
BeaconState.hashTreeRoot - 1 full validator 150.18 us/op 236.32 us/op 0.64
BeaconState.hashTreeRoot - 32 full validator 1.4399 ms/op 2.7098 ms/op 0.53
BeaconState.hashTreeRoot - 512 full validator 16.159 ms/op 24.159 ms/op 0.67
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 178.13 us/op 242.92 us/op 0.73
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.5053 ms/op 3.2249 ms/op 0.78
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 32.942 ms/op 43.732 ms/op 0.75
BeaconState.hashTreeRoot - 1 balances 151.98 us/op 189.85 us/op 0.80
BeaconState.hashTreeRoot - 32 balances 1.4542 ms/op 1.7412 ms/op 0.84
BeaconState.hashTreeRoot - 512 balances 14.210 ms/op 19.888 ms/op 0.71
BeaconState.hashTreeRoot - 250000 balances 189.67 ms/op 315.34 ms/op 0.60
aggregationBits - 2048 els - zipIndexesInBitList 16.123 us/op 43.688 us/op 0.37
regular array get 100000 times 33.941 us/op 70.874 us/op 0.48
wrappedArray get 100000 times 33.905 us/op 71.376 us/op 0.48
arrayWithProxy get 100000 times 14.887 ms/op 18.318 ms/op 0.81
ssz.Root.equals 210.00 ns/op 355.00 ns/op 0.59
byteArrayEquals 216.00 ns/op 339.00 ns/op 0.64
shuffle list - 16384 els 7.1115 ms/op 8.5713 ms/op 0.83
shuffle list - 250000 els 104.04 ms/op 127.44 ms/op 0.82
processSlot - 1 slots 15.918 us/op 23.731 us/op 0.67
processSlot - 32 slots 3.0168 ms/op 4.9891 ms/op 0.60
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 51.369 ms/op 64.586 ms/op 0.80
getCommitteeAssignments - req 1 vs - 250000 vc 2.5525 ms/op 2.9018 ms/op 0.88
getCommitteeAssignments - req 100 vs - 250000 vc 3.7867 ms/op 4.2675 ms/op 0.89
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1398 ms/op 5.1379 ms/op 0.81
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5700 ns/op 6.8300 ns/op 0.67
state getBlockRootAtSlot - 250000 vs - 7PWei 700.46 ns/op 720.37 ns/op 0.97
computeProposers - vc 250000 9.4403 ms/op 10.264 ms/op 0.92
computeEpochShuffling - vc 250000 105.96 ms/op 120.93 ms/op 0.88
getNextSyncCommittee - vc 250000 156.28 ms/op 177.55 ms/op 0.88
computeSigningRoot for AttestationData 24.951 us/op 31.778 us/op 0.79
hash AttestationData serialized data then Buffer.toString(base64) 2.2963 us/op 2.7157 us/op 0.85
toHexString serialized data 1.0592 us/op 2.0674 us/op 0.51
Buffer.toString(base64) 219.75 ns/op 305.32 ns/op 0.72

by benchmarkbot/action

@wemeetagain wemeetagain merged commit caa0250 into unstable Sep 23, 2023
@wemeetagain wemeetagain deleted the nflaig/misc-changes branch September 23, 2023 19:28
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain